Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

docs(migration): update to use new runtimeConfig#4642

Merged
pi0 merged 4 commits intonuxt:mainfrom
tobiasdiez:patch-1
Apr 27, 2022
Merged

docs(migration): update to use new runtimeConfig#4642
pi0 merged 4 commits intonuxt:mainfrom
tobiasdiez:patch-1

Conversation

@tobiasdiez
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The migration guide still mentioned the deprecated publicRuntimeConfig and privateRuntimeConfig, this is changed to the new runtimeConfig.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Apr 26, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit 116dcb9
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/626907034d7c2d0008e1c753
😎 Deploy Preview https://deploy-preview-4642--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

secretKey: '', // variable that can only be accessed on server-side
public: {
BASE_URL: process.env.BASE_URL || 'https://nuxtjs.org'
BASE_URL: process.env.BASE_URL || 'https://nuxtjs.org' // variable that can also be accessed on the client-side
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BASE_URL: process.env.BASE_URL || 'https://nuxtjs.org' // variable that can also be accessed on the client-side
BASE_URL: process.env.BASE_URL || 'https://nuxtjs.org' // variable that can also be accessed on the client side

pi0 and others added 3 commits April 27, 2022 11:03
Co-authored-by: Damian <48835293+DamianGlowala@users.noreply.github.com>
Co-authored-by: Damian <48835293+DamianGlowala@users.noreply.github.com>
Co-authored-by: Damian <48835293+DamianGlowala@users.noreply.github.com>
@pi0 pi0 changed the title docs: Use runtimeConfig in migration guide docs: update to use new runtimeConfig in migration guide Apr 27, 2022
@pi0 pi0 changed the title docs: update to use new runtimeConfig in migration guide docs(migration): update to use new runtimeConfig Apr 27, 2022
@pi0 pi0 merged commit ee0b90b into nuxt:main Apr 27, 2022
@pi0
Copy link
Member

pi0 commented Apr 27, 2022

Thanks @tobiasdiez @DamianGlowala

@tobiasdiez tobiasdiez deleted the patch-1 branch April 27, 2022 09:10
@pi0 pi0 mentioned this pull request May 2, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants