This repository was archived by the owner on Apr 6, 2023. It is now read-only.
Conversation
…nothing
Avoids rollup error `plugin load hook should return a string, a { code, map } object, or nothing/null` when using (custom) virtual imports.
✅ Deploy Preview for nuxt3-docs canceled.
|
danielroe
approved these changes
May 5, 2022
Member
danielroe
left a comment
There was a problem hiding this comment.
This seems like a good fix to me. Alternatively, we could change the prefix we're using here to virtual:nuxt or something.
virtual: imports that aren't in vfs
Member
|
@danielroe Can you please check failing CI? |
danielroe
reviewed
May 6, 2022
danielroe
reviewed
May 6, 2022
virtual: imports that aren't in vfs
pi0
approved these changes
May 6, 2022
Member
|
Thanks @derz 💯 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids rollup error
plugin load hook should return a string, a { code, map } object, or nothing/nullwhen using (custom) virtual imports.🔗 Linked issue
nuxt/nuxt#13921
❓ Type of change
📚 Description
Check if the virtual module exist in nuxt and otherwise just ignore it (aka leave it up for the other loaders to handle that module). Avoids returning
{ code: null, map: null }.Resolves nuxt/nuxt#13921
📝 Checklist