Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt) : add default value for nitro.rollupConfig.plugins#4830

Merged
pi0 merged 1 commit intonuxt:mainfrom
huang-julien:fix/undefined-rollup-config
May 6, 2022
Merged

fix(nuxt) : add default value for nitro.rollupConfig.plugins#4830
pi0 merged 1 commit intonuxt:mainfrom
huang-julien:fix/undefined-rollup-config

Conversation

@huang-julien
Copy link
Member

🔗 Linked issue

resolve nuxt/nuxt#13927

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

rollup config is undefined and the import plugin registration is trying to push the plugin into an empty array here.
fixed by setting

    rollupConfig: {
      plugins: []
    }

into nitroConfig at package/nuxt/core/nitro.ts

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented May 5, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 0797d7a
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62745bc00522840008f7a595

@pi0 pi0 changed the title fix(nuxt) : fix call on undefined array when building fix(nuxt) : add default value for nitro.rollupConfig.plugins May 6, 2022
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@pi0 pi0 merged commit 6b16711 into nuxt:main May 6, 2022
@pi0 pi0 mentioned this pull request May 6, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trying to push the ImportProtectionPlugin into an undefined array

3 participants