This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): normalise window location for universal router#4841
Merged
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
reviewed
May 6, 2022
pi0
reviewed
May 6, 2022
pi0
approved these changes
May 6, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
currently
route.fullPathis/on server andhttp://localhost:3000/on client. This implements same behaviour as on router, which also fixes an issue where baseURL wasn't being correctly handled with universal router:framework/packages/nuxt/src/pages/runtime/router.ts
Lines 30 to 49 in ebc27ce
📝 Checklist