Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): check if default slot is provided before calling it#4842

Merged
pi0 merged 1 commit intomainfrom
fix/default-slots
May 6, 2022
Merged

fix(nuxt): check if default slot is provided before calling it#4842
pi0 merged 1 commit intomainfrom
fix/default-slots

Conversation

@danielroe
Copy link
Member

🔗 Linked issue

resolves nuxt/nuxt#13935

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We should generally check if default slot is provided before calling it. This applies it across several different situations throughout the Nuxt app.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented May 6, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 6a01bc4
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6274f6ad8833ed0008b1e942

@danielroe danielroe self-assigned this May 6, 2022
@danielroe danielroe requested a review from pi0 May 6, 2022 10:21
@danielroe danielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels May 6, 2022
@pi0 pi0 merged commit 7504606 into main May 6, 2022
@pi0 pi0 deleted the fix/default-slots branch May 6, 2022 10:52
@pi0 pi0 mentioned this pull request May 6, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty NuxtLink component with target="_blank" - Error 500 - slots.default is not a function

2 participants