Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): configure vite to transpile nuxt#4915

Merged
pi0 merged 3 commits intomainfrom
fix/transpile-export
May 10, 2022
Merged

fix(nuxt): configure vite to transpile nuxt#4915
pi0 merged 3 commits intomainfrom
fix/transpile-export

Conversation

@danielroe
Copy link
Member

@danielroe danielroe commented May 10, 2022

🔗 Linked issue

resolves nuxt/nuxt#13953

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We shouldn't need nitro to transpile these (or we actually end up with duplicates in the server bundle.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels May 10, 2022
@danielroe danielroe requested a review from pi0 May 10, 2022 12:47
@danielroe danielroe self-assigned this May 10, 2022
@netlify
Copy link

netlify bot commented May 10, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 0595999
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/627a70d97fb1b200084572f6

@danielroe danielroe changed the title fix(nuxt): add nuxt transpiles to nitro inlines fix(nuxt): configure vite to transpile nuxt May 10, 2022
@danielroe danielroe marked this pull request as draft May 10, 2022 13:24
@danielroe danielroe marked this pull request as ready for review May 10, 2022 13:49
@pi0 pi0 merged commit 3359b3b into main May 10, 2022
@pi0 pi0 deleted the fix/transpile-export branch May 10, 2022 15:11
@pi0
Copy link
Member

pi0 commented May 10, 2022

(commit reverted due to issues it was making @ 3.0.0-rc.3-27536597.3359b3b )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nuxt/app imports are being externalised

2 participants