This repository was archived by the owner on Apr 6, 2023. It is now read-only.
feat(nuxt): tree-shake client and server-only composables#5749
Merged
Conversation
danielroe
added
enhancement
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
7 tasks
antfu
reviewed
Jul 6, 2022
pi0
reviewed
Jul 6, 2022
pi0
reviewed
Jul 6, 2022
pi0
changed the title
danielroe
force-pushed
the
feat/shake-composables
branch
from
7270a45 to
37d6823
Compare
pi0
approved these changes
Jul 7, 2022
Member
pi0
left a comment
pi0
left a comment
There was a problem hiding this comment.
LGTM! Nice work (didn't tried locally)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt/nuxt#14192
❓ Type of change
📚 Description
Certain vue composables are only called in a given context, and we can optimise our builds be extracting them. For example, a dynamic import in
onMounteddoesn't need to create a chunk (or worse, be inlined - see #5506) in the server build.📝 Checklist