Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxt, schema): add <NoScript> component and noscript typings#6139

Merged
pi0 merged 5 commits intonuxt:mainfrom
vis97c:main
Jul 26, 2022
Merged

feat(nuxt, schema): add <NoScript> component and noscript typings#6139
pi0 merged 5 commits intonuxt:mainfrom
vis97c:main

Conversation

@vis97c
Copy link
Contributor

@vis97c vis97c commented Jul 26, 2022

🔗 Linked issue

nuxt/nuxt#13848

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Following @danielroe & @pi0 recommendations I'm adding typings for the meta feature noscript

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit fb3a7b4
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62dfee41d0c1b400091fb04e

@danielroe danielroe changed the title docs: add noscript typings & documentation feat: add noscript typings & documentation Jul 26, 2022
@danielroe danielroe changed the title feat: add noscript typings & documentation feat(nuxt, schema): add noscript typings, component and documentation Jul 26, 2022
Co-authored-by: Daniel Roe <daniel@roe.dev>
@pi0 pi0 changed the title feat(nuxt, schema): add noscript typings, component and documentation feat(nuxt, schema): add <NoScript> component and noscript typings Jul 26, 2022
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pi0 pi0 merged commit 5d023a8 into nuxt:main Jul 26, 2022
@vis97c
Copy link
Contributor Author

vis97c commented Jul 26, 2022

Oh wow didn't expected you to do the fixes. It was already late so i just wanted to send the pr and fix it later. Thanks @pi0 @danielroe

@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants