This repository was archived by the owner on Apr 6, 2023. It is now read-only.
Conversation
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
7 tasks
pi0
approved these changes
Aug 2, 2022
Member
|
Thanks! |
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related PR: vueuse/head@1382c43
❓ Type of change
📚 Description
When working on #6293, I updated the @vueuse/head package to get the dedupe fix.
In updating, I noticed that all titles had duplicate template processing. For example
Home - My Title, becameHome - My Title - My Title. This was due to @vueuse/head introducing its own titleTemplate feature.I figured the best course of action would be to adopt the native titleTemplate logic which, as far as I tested, includes the same feature set.
All seems to work well, however, there is one very minor "breaking" change. In the documentation, it recommended setting
titleTemplatetoundefinedto disable it. This is not possible with these changes, so the doc is updated to usenullinstead. The @vueuse/head package ignores null values so we need to cast it to an empty string.📝 Checklist