This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): do not log 404 and showError as fatal by default#6437
Merged
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
danielroe
approved these changes
Aug 8, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
With #4539 and h3js/h3#148 we introduced new
fatalflag for error that are intended to be logged. 404 Page not found errors we throw are not fatal to be verbosely logged by h3.Also with this change,
showErrorby default does not set fatality of error but only mark there is an error and display it (locally testing works both when calling from client and server side).Related: In future versions of h3, we might make createError smarter to infer fatal flag from known codes.
Appendix current output:
📝 Checklist