This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt)!: allow app:rendered to modify ssr context and add render:html #6521
Merged
fix(nuxt)!: allow app:rendered to modify ssr context and add render:html #6521
app:rendered to modify ssr context and add render:html #6521Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
danielroe
approved these changes
Aug 11, 2022
app:rendered hook to modify ssr contextapp:rendered to modify ssr context and add render:html
Merged
danielroe
reviewed
Aug 11, 2022
danielroe
reviewed
Aug 11, 2022
This was referenced Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves nuxt/nuxt#14537
❓ Type of change
📚 Description
We were calling
app:renderedhook just after ssr rendering is being done in Nuxt 3 <= 3.0.0-rc.6. #6042 changed this behavior in v3.0.0-rc.7 thatapp:renderedis being called with newrenderedcontext to have access to constructed html but this means, it is too late to modify payload.This PR reverts
app:renderedback to previous behavior with new limited{ ssrContext }context only. (breaking change)Nitro plugins have access to the final rendered context via
render:html(breaking change:nuxt:app:renderedrenamed for nitro plugins to be simpler, consistent withrender:responsehook and not confused withapp:renderedlifecycle hook)Example usage: (nitro plugin)
📝 Checklist