Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): include tag attrs for non self-closing tags in tree-shake regex#6675

Merged
pi0 merged 3 commits intonuxt:mainfrom
huang-julien:fix/treeshake-client-self-closing
Aug 16, 2022
Merged

fix(nuxt): include tag attrs for non self-closing tags in tree-shake regex#6675
pi0 merged 3 commits intonuxt:mainfrom
huang-julien:fix/treeshake-client-self-closing

Conversation

@huang-julien
Copy link
Member

@huang-julien huang-julien commented Aug 16, 2022

🔗 Linked issue

resolve nuxt/nuxt#14606

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hi, this PR aims to add missing attributes when the tag is not a self-closing tag by fixing the regex. Previously, attributes were missing on non self-closing tags.

Test fixtures of this PR can be considered as included by PR #6584 ?

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 1e39273
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62fb8cd941f5b7000957f5a0

huang-julien and others added 2 commits August 16, 2022 14:21
Co-authored-by: Daniel Roe <daniel@roe.dev>
@pi0 pi0 merged commit a3a8706 into nuxt:main Aug 16, 2022
@pi0
Copy link
Member

pi0 commented Aug 16, 2022

Thanks @huang-julien @danielroe <3

@pi0 pi0 mentioned this pull request Aug 26, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tree-shake components don't pass attrs with non self-closing tags

3 participants