This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(vite, webpack): avoid generating keys where a key is already provided#7622
Merged
fix(vite, webpack): avoid generating keys where a key is already provided#7622
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
Member
|
I love this as workaround but also it can be even trickier in the future when we support more arguments (like 3rd options to useState) and if first arg is not a string but variable/reference. Thinking if we could change auto key injection method to be safe out of the box. |
Member
Author
|
You're right that we would need to update if we add more args, but the main thing it is protecting against is duplicate string keys at the end of the argument chain, which is what causes the issue. Detecting explicit keys at the beginning is only an added benefit - not a bug fix. |
pi0
approved these changes
Sep 19, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#14932
❓ Type of change
📚 Description
With webpack, we were processing code twice and therefore injecting several auto-generated keys, one after the other. This PR prevents double-insertion of keys, and also prevents insertion when there is an obvious string or template literal key provided already.
It also excludes nuxt sourcefiles (e.g.
#app) from having keys inserted into them.📝 Checklist