Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): don't treeshake client-only fallback templates#7659

Merged
pi0 merged 1 commit intomainfrom
fix/client-only-fallback
Sep 20, 2022
Merged

fix(nuxt): don't treeshake client-only fallback templates#7659
pi0 merged 1 commit intomainfrom
fix/client-only-fallback

Conversation

@danielroe
Copy link
Member

🔗 Linked issue

resolves nuxt/nuxt#14896

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is an alternative approach to #7527, using pure regexp to handle fallback/placeholder slots.

It also fixes a bug where we matched partial component names.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 19, 2022
@danielroe danielroe requested a review from pi0 September 19, 2022 21:24
@danielroe danielroe self-assigned this Sep 19, 2022
@netlify
Copy link

netlify bot commented Sep 19, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit a4a7638
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6328de2d5a62e50008b9f638

@pi0 pi0 merged commit f8a2356 into main Sep 20, 2022
@pi0 pi0 deleted the fix/client-only-fallback branch September 20, 2022 06:24
@pi0 pi0 mentioned this pull request Sep 20, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<ClientOnly> with <template #fallback> always results in hydration error in RC10

2 participants