Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxi): include workspaceDir in tsconfig include#7726

Merged
pi0 merged 5 commits intomainfrom
fix/workspace-tsconfig
Sep 22, 2022
Merged

fix(nuxi): include workspaceDir in tsconfig include#7726
pi0 merged 5 commits intomainfrom
fix/workspace-tsconfig

Conversation

@danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

In some cases, such as module development, we want to be able to use types for things like #app in a workspace rather than just within the nuxt root directory. This allows extending a tsconfig.json in a parent directory (e.g. https://github.com/nuxt/starter/blob/module/tsconfig.json#L2).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added enhancement New feature or request cli labels Sep 21, 2022
@danielroe danielroe requested a review from pi0 September 21, 2022 14:23
@danielroe danielroe self-assigned this Sep 21, 2022
@codesandbox
Copy link

codesandbox bot commented Sep 21, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Sep 21, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit f34003a
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/632b27aa65dcf70009870450
😎 Deploy Preview https://deploy-preview-7726--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe danielroe added bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 21, 2022
Copy link
Member

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Adds "../../**/*" to the playground/.nuxt/tsconfig.json's includes as intended.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working cli enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants