This repository was archived by the owner on Apr 6, 2023. It is now read-only.
perf(nuxt): use simple JSON.stringify to compare params#8340
Merged
Conversation
|
|
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#8327
❓ Type of change
📚 Description
Using
JSON.stringifyto compare two route params as suggested by @atinux. It saves 1.53Kb gzip (~1.6%) bundle size when pages are enabled by not importingohash. Difference is that we assume order of params remains same.Note: we probably need this library in other places in the future such as
useFetchif depending on URL again (#6632).📝 Checklist