Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): don't load payloads for external urls#8370

Merged
pi0 merged 2 commits intomainfrom
fix/external-payloads
Oct 21, 2022
Merged

fix(nuxt): don't load payloads for external urls#8370
pi0 merged 2 commits intomainfrom
fix/external-payloads

Conversation

@danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Regression of #8225. We need to ensure we're only loading payloads for internal URLs. (Actually we need to implement something like #7805 as a proper fix.)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Oct 20, 2022
@danielroe danielroe requested a review from pi0 October 20, 2022 20:55
@danielroe danielroe self-assigned this Oct 20, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 20, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit 4c2f563
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6352551e03f33d0008840f20
😎 Deploy Preview https://deploy-preview-8370--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0 pi0 merged commit e1ab5cf into main Oct 21, 2022
@pi0 pi0 deleted the fix/external-payloads branch October 21, 2022 08:28
@pi0 pi0 mentioned this pull request Nov 3, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants