Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

refactor(schema)!: disable app.pageTransition and app.layoutTransition by default#8436

Merged
pi0 merged 5 commits intomainfrom
fix/disable-transitions
Oct 24, 2022
Merged

refactor(schema)!: disable app.pageTransition and app.layoutTransition by default#8436
pi0 merged 5 commits intomainfrom
fix/disable-transitions

Conversation

@danielroe
Copy link
Member

🔗 Linked issue

#8434 (comment)

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This disables page/layout transitions by default. They cause issues like nuxt/nuxt#13471 and nuxt/nuxt#15239 when many users may not be using them at all ...

 👉 Migration

If you were using page/layout transitions, you can add the following to your nuxt config to re-enable the previous behaviour:

export default defineNuxtConfig({
  app: {
    pageTransition: { name: 'page', mode: 'out-in' },
    layoutTransition: { name: 'layout', mode: 'out-in' }
  },
})

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested review from atinux and pi0 October 24, 2022 08:50
@danielroe danielroe self-assigned this Oct 24, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 24, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 24, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit e47c6b0
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63566e1a2300040009fc0b2e
😎 Deploy Preview https://deploy-preview-8436--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atinux
Copy link
Member

atinux commented Oct 24, 2022

Thank you @danielroe

We need to update the documentation as well (https://v3.nuxtjs.org/getting-started/transitions) to explain how to enable page transition and layouts transitions.

@danielroe
Copy link
Member Author

Thank you - good catch! 🙏

@pi0 pi0 changed the title fix(schema)!: disable page/layout transitions by default fix(schema)!: disable app.pageTransition and app. layoutTransition by default Oct 24, 2022
@pi0 pi0 changed the title fix(schema)!: disable app.pageTransition and app. layoutTransition by default refactor(schema)!: disable app.pageTransition and app. layoutTransition by default Oct 24, 2022
@danielroe danielroe changed the title refactor(schema)!: disable app.pageTransition and app. layoutTransition by default refactor(schema)!: disable app.pageTransition and app.layoutTransition by default Oct 24, 2022
@danielroe
Copy link
Member Author

danielroe commented Oct 24, 2022

Fixing test failure. On plane, so may take a minute.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants