fix: fix types for custom providers shadowing builtins#2016
Conversation
… as built in providers 🦖
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2016 +/- ##
========================================
- Coverage 7.00% 6.99% -0.01%
========================================
Files 78 78
Lines 3625 3629 +4
Branches 140 140
========================================
Hits 254 254
- Misses 3322 3326 +4
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielroe
left a comment
There was a problem hiding this comment.
I wonder if we can resolve this with type safety by telling custom provider authors how to augment these interfaces
Not sure how I would implement that 😁 |
|
pushed a change - does this work in your use case? |
@danielroe yes that works and those changes look a little cleaner than mine 👍 Thank you |
fix correct type generation for custom providers with same name as built in providers
🔗 Linked issue
resolves #2015
❓ Type of change
📚 Description
This fixes the ttype generation for cases where custom providers have the same name as built in providers.