fix(nuxt-picture): allow data-* in imgAttrs#2017
Merged
danielroe merged 1 commit intoNov 16, 2025
Merged
Conversation
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2017 +/- ##
========================================
- Coverage 7.07% 7.07% -0.01%
========================================
Files 77 77
Lines 3590 3591 +1
Branches 139 139
========================================
Hits 254 254
- Misses 3288 3289 +1
Partials 48 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielroe
reviewed
Nov 6, 2025
| export interface PictureProps<Provider extends keyof ConfiguredImageProviders> extends BaseImageProps<Provider> { | ||
| legacyFormat?: string | ||
| imgAttrs?: ImgHTMLAttributes | ||
| imgAttrs?: ImgHTMLAttributes & DataAttributes |
Member
There was a problem hiding this comment.
I think Vue itself might expose the types we need here
we did something similar for NuxtLink recently
Contributor
Author
danielroe
approved these changes
Nov 16, 2025
data-* in imgAttrs
Member
|
thank you! ❤️ |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🔗 Linked issue
resolves #2013
❓ Type of change
📚 Description
This fixes a typescript issue, that would give a typescript error when passing a
data-*to NuxtImage imgAttrs prop.