fix(bunny): merge query params with existing image src#2054
Merged
Conversation
commit: |
danielroe
reviewed
Dec 12, 2025
|
|
||
| const operationsGenerator = createOperationsGenerator({ | ||
| keyMap: { | ||
| const operationsGenerator = createMapper({ |
Member
There was a problem hiding this comment.
is there a reason you changed this? I think it's causing the type checking errors below
Contributor
Author
There was a problem hiding this comment.
Because withQuery needs an mapped object instead of a concatenated query string.
952df27 to
ea8bedc
Compare
In case the image src already contains a query parameter, it is necessary to properly add bunny query params. This is accomplished using withQuery helper from ufo.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2054 +/- ##
=====================================
Coverage 6.99% 6.99%
=====================================
Files 78 78
Lines 3629 3629
Branches 140 140
=====================================
Hits 254 254
Misses 3326 3326
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielroe
approved these changes
Dec 16, 2025
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case the image src already contains a query parameter, it is necessary to properly add bunny query params. This is accomplished using withQuery helper from ufo.
🔗 Linked issue
resolves #2055
❓ Type of change
📚 Description
In case the image src already contains a query parameter, it is necessary to properly add bunny query params. This is accomplished using withQuery helper from ufo.
e.g. url is http://example.com/image.jpg?timestamp