Skip to content

fix: wrap importName with genSafeVariableName#2092

Merged
danielroe merged 1 commit into
mainfrom
fix/gensafevariablename
Jan 20, 2026
Merged

fix: wrap importName with genSafeVariableName#2092
danielroe merged 1 commit into
mainfrom
fix/gensafevariablename

Conversation

@huang-julien
Copy link
Copy Markdown
Member

@huang-julien huang-julien commented Jan 19, 2026

🔗 Linked issue

fix #2093

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR wraps importName with genSafeVariable so users can use kebab-cased key.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jan 19, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@2092

commit: 7146dad

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying nuxt-image with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7146dad
Status: ✅  Deploy successful!
Preview URL: https://12ab9ab2.nuxt-image.pages.dev
Branch Preview URL: https://fix-gensafevariablename.nuxt-image.pages.dev

View logs

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 6.99%. Comparing base (44057b7) to head (7146dad).

Files with missing lines Patch % Lines
src/provider.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2092   +/-   ##
=====================================
  Coverage   6.99%   6.99%           
=====================================
  Files         78      78           
  Lines       3632    3632           
  Branches     140     140           
=====================================
  Hits         254     254           
  Misses      3329    3329           
  Partials      49      49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe danielroe merged commit ae8bf31 into main Jan 20, 2026
8 checks passed
@danielroe danielroe deleted the fix/gensafevariablename branch January 20, 2026 00:07
@github-actions github-actions Bot mentioned this pull request Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

having custom providers in kebab-case break the server

3 participants