fix: reduce max-width breakpoint values by 1px#2132
Conversation
Deploying nuxt-image with
|
| Latest commit: |
187f862
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fbf50966.nuxt-image.pages.dev |
| Branch Preview URL: | https://fix-off-by-one-max-width.nuxt-image.pages.dev |
commit: |
📝 WalkthroughWalkthroughThis pull request adjusts responsive image breakpoint calculations by reducing media query thresholds by 1 pixel. The primary change modifies Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2132 +/- ##
=====================================
Coverage 6.83% 6.83%
=====================================
Files 80 80
Lines 3729 3729
Branches 142 142
=====================================
Hits 255 255
Misses 3424 3424
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔗 Linked issue
resolves #1235
📚 Description
This addresses a bug with off by one values for breakpoints using max-width media query.