Skip to content

fix(directus): add withoutEnlargement modifier type#2133

Merged
danielroe merged 3 commits into
mainfrom
feat/directus-without-enlargement
Feb 24, 2026
Merged

fix(directus): add withoutEnlargement modifier type#2133
danielroe merged 3 commits into
mainfrom
feat/directus-without-enlargement

Conversation

@DamianGlowala
Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #2105

📚 Description

Adds types for withoutEnlargement modifier in Directus provider.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 24, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@2133

commit: ca9faec

@danielroe danielroe changed the title types: add withoutEnlargement modifier to directus provider fix(directus): add withoutEnlargement modifier Feb 24, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Feb 24, 2026

Deploying nuxt-image with  Cloudflare Pages  Cloudflare Pages

Latest commit: ca9faec
Status: ✅  Deploy successful!
Preview URL: https://c0a7f902.nuxt-image.pages.dev
Branch Preview URL: https://feat-directus-without-enlarg.nuxt-image.pages.dev

View logs

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 24, 2026

📝 Walkthrough

Walkthrough

The changes update type definitions for the Directus image provider and the operations generator utility. The Directus provider's modifiers interface is updated to make the transforms field optional and add the missing withoutEnlargement boolean modifier. The operations generator utility is updated to allow ModifierValue to be string | boolean | number instead of just string | number, broadening the accepted modifier value types at the type level without altering runtime behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The PR description is directly related to the changeset, explaining that it adds TypeScript types for the withoutEnlargement modifier in the Directus provider.
Linked Issues check ✅ Passed The PR adds the withoutEnlargement boolean modifier type to DirectusOptions.modifiers and updates the type parameter to support boolean values, directly addressing the type definition gap described in issue #2105.
Out of Scope Changes check ✅ Passed All changes are scoped to adding the withoutEnlargement modifier type definition and updating the generic type parameter to support boolean modifier values, which are necessary and in-scope changes.
Title check ✅ Passed The title accurately describes the main change - adding the withoutEnlargement modifier type to the Directus provider.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/directus-without-enlargement

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe changed the title fix(directus): add withoutEnlargement modifier fix(directus): add withoutEnlargement modifier type Feb 24, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 6.83%. Comparing base (15db7f8) to head (ca9faec).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2133   +/-   ##
=====================================
  Coverage   6.83%   6.83%           
=====================================
  Files         80      80           
  Lines       3732    3732           
  Branches     142     142           
=====================================
  Hits         255     255           
  Misses      3427    3427           
  Partials      50      50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe danielroe enabled auto-merge (squash) February 24, 2026 23:17
@danielroe danielroe merged commit 9b1a21c into main Feb 24, 2026
9 checks passed
@danielroe danielroe deleted the feat/directus-without-enlargement branch February 24, 2026 23:22
@github-actions github-actions Bot mentioned this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Directus provider: withoutEnlargement modifier supported at runtime but missing in type definitions

3 participants