fix(shopify): merge preexisting query params with modifiers#2135
Conversation
commit: |
Deploying nuxt-image with
|
| Latest commit: |
d2ec1fa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3fc0ddcd.nuxt-image.pages.dev |
| Branch Preview URL: | https://fix-shopify-img-src-with-que.nuxt-image.pages.dev |
📝 WalkthroughWalkthroughThe changes refactor the Shopify provider's URL construction method to properly handle pre-existing query parameters in source URLs. The implementation replaces manual string concatenation with Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2135 +/- ##
========================================
- Coverage 6.83% 6.83% -0.01%
========================================
Files 80 80
Lines 3729 3732 +3
Branches 142 142
========================================
Hits 255 255
- Misses 3424 3427 +3
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔗 Linked issue
resolves #2047
❓ Type of change
📚 Description
It correctly merges preexisting query params with any modifiers for Shopify provider.