Skip to content

chore: remove unused slot-related code from <NuxtPicture>#2145

Merged
danielroe merged 1 commit into
mainfrom
chore/nuxt-picture-dead-code
Feb 26, 2026
Merged

chore: remove unused slot-related code from <NuxtPicture>#2145
danielroe merged 1 commit into
mainfrom
chore/nuxt-picture-dead-code

Conversation

@DamianGlowala
Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

@DamianGlowala DamianGlowala changed the title chore: remove unused slot-related code from <NutPicture> chore: remove unused slot-related code from <NuxtPicture> Feb 26, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 26, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@2145

commit: 58417b7

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 510f2e1 and 58417b7.

📒 Files selected for processing (1)
  • src/runtime/components/NuxtPicture.vue
💤 Files with no reviewable changes (1)
  • src/runtime/components/NuxtPicture.vue

📝 Walkthrough

Walkthrough

This change removes type definitions for the default slot of the NuxtPicture component. Specifically, it deletes the defineSlots declaration that typed the default slot with DefaultSlotProps and removes the DefaultSlotProps interface definition. The component's public slot-related type declarations are reduced by 9 lines.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is a template with placeholder sections and no actual content describing the changes, making it vague and uninformative. Provide a meaningful description explaining why the slot-related code is unused and the rationale for its removal.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removal of unused slot-related code from NuxtPicture component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/nuxt-picture-dead-code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying nuxt-image with  Cloudflare Pages  Cloudflare Pages

Latest commit: 58417b7
Status: ✅  Deploy successful!
Preview URL: https://fa331796.nuxt-image.pages.dev
Branch Preview URL: https://chore-nuxt-picture-dead-code.nuxt-image.pages.dev

View logs

@danielroe danielroe added this pull request to the merge queue Feb 26, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.52%. Comparing base (510f2e1) to head (58417b7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2145   +/-   ##
=======================================
  Coverage   32.52%   32.52%           
=======================================
  Files           7        7           
  Lines         372      372           
  Branches      131      131           
=======================================
  Hits          121      121           
  Misses        194      194           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into main with commit 55ed687 Feb 26, 2026
11 checks passed
@danielroe danielroe deleted the chore/nuxt-picture-dead-code branch February 26, 2026 23:15
@github-actions github-actions Bot mentioned this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants