Use Legion with CMake's native CUDA language

.dockerignore

@@ -0,0 +1,44 @@
+*~
+\#*#
+*/typestubs/*
+.#*
+.DS_Store
+*.a
+*.d
+*.o
+*.so
+*.gz
+*.gcno
+*.gcda
+*.gcov
+*.fluid
+*.pyc
+*.swp
+*.log
+*.bbl
+*.blg
+*.aux
+*.json
+*.dylib
+install_info.py
+/dist
+/build
+/legion
+/install*
+/_skbuild
+config.mk
+/docs/legate/core/build
+/docs/legate/core/source/api/generated
+*.egg-info
+.creds
+.cache
+.coverage
+.vscode
+_cmake_test_compile
+!cmake/versions.json
+legate.core.code-workspace
+*.prof
+.legate-test-last-failed
+out/
+.github/
+continuous_integration/Dockerfile

.github/workflows/ci-gh-cpu-build-and-test.yml

@@ -5,15 +5,22 @@ concurrency:
   cancel-in-progress: true
 
 on:
+  pull_request:
   push:
     branches:
       - "pull-request/[0-9]+"
       - "branch-*"
 
 jobs:
+  filter-by-triggering-event:
+    name: Filter by triggering event
+    uses: ./.github/workflows/filter-by-triggering-event.yml
+
   build-cpu:
-    uses:
-      ./.github/workflows/gh-build.yml
+    needs: filter-by-triggering-event
+    if: needs.filter-by-triggering-event.outputs.ok == 'true'
+    secrets: inherit
+    uses: ./.github/workflows/gh-build.yml
     with:
       build-target: cpu
       # Ref: https://docs.rapids.ai/resources/github-actions/#cpu-labels for `linux-amd64-cpu4`
@@ -27,15 +34,16 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - { name: Pytest Unit Tests, test-scope: unit }
-          - { name: mypy, test-scope: mypy }
+          - { name: pytest, test-scope: test }
+          - { name: mypy, test-scope: type-check }
     name: ${{ matrix.name }}
-    uses:
-      ./.github/workflows/gh-test.yml
+    secrets: inherit
+    uses: ./.github/workflows/gh-test.yml
     with:
       build-target: cpu
       runs-on: ${{ github.repository == 'nv-legate/legate.core' && 'linux-amd64-cpu4' || 'ubuntu-latest' }}
       sha: ${{ github.sha }}
+      test-name: ${{ matrix.name }}
       test-scope: ${{ matrix.test-scope }}
 
   cleanup:
@@ -44,8 +52,8 @@ jobs:
       - test-cpu
     # This ensures the cleanup job runs even if previous jobs fail or the workflow is cancelled.
     if: always()
-    uses:
-      ./.github/workflows/gh-cleanup.yml
+    secrets: inherit
+    uses: ./.github/workflows/gh-cleanup.yml
     with:
       build-target: cpu
       sha: ${{ github.sha }}

.github/workflows/ci-gh-docs.yml

@@ -4,6 +4,7 @@ on:
   push:
     branches-ignore:
       - gh-pages  # deployment target branch (this workflow should not exist on that branch anyway)
+      - "pull-request/[0-9]+"
   pull_request:
     branches-ignore:
       - gh-pages  # deployment target branch (this workflow should not exist on that branch anyway)
@@ -44,14 +45,14 @@ jobs:
         env:
           MATRIX_CONTEXT: ${{ toJSON(matrix) }}
         run: echo "$MATRIX_CONTEXT"
-      
+
       ####################################
       # Actual build process starts here #
       ####################################
-      
+
       - name: Checkout
         uses: actions/checkout@v3
-      
+
       - name: Generate YAML file listing dependencies
         run: scripts/generate-conda-envs.py --python 3.10 --ctk 11.8 --os linux --compilers --openmpi
 
@@ -61,7 +62,7 @@ jobs:
       - name: Build doxygen documentation through install.py
         run: |
           conda run -n legate /bin/bash -c "./install.py --docs"
-      
+
       - name: Build documentation using Makefile
         working-directory: ./docs/legate/core
         run: |

.github/workflows/ci-gh-gpu-build-and-test.yml

@@ -5,38 +5,47 @@ concurrency:
   cancel-in-progress: true
 
 on:
+  pull_request:
   push:
     branches:
       - "pull-request/[0-9]+"
       - "branch-*"
 
 jobs:
+  filter-by-triggering-event:
+    name: Filter by triggering event
+    uses: ./.github/workflows/filter-by-triggering-event.yml
+
   build-gpu:
-    uses:
-      ./.github/workflows/gh-build.yml
+    needs: filter-by-triggering-event
+    if: needs.filter-by-triggering-event.outputs.ok == 'true'
+    secrets: inherit
+    uses: ./.github/workflows/gh-build.yml
     with:
       build-target: gpu
       # Ref: https://docs.rapids.ai/resources/github-actions/#cpu-labels for `linux-amd64-cpu4`
       runs-on: ${{ github.repository == 'nv-legate/legate.core' && 'linux-amd64-cpu4' || 'ubuntu-latest' }}
       sha: ${{ github.sha }}
 
   test-gpu:
+    if: github.repository == 'nv-legate/legate.core'
     needs:
       - build-gpu
     strategy:
       fail-fast: false
       matrix:
         include:
-          - { name: Pytest Unit Tests, test-scope: unit, runner: linux-amd64-gpu-v100-latest-1 }
-          - { name: Pytest Unit Tests, test-scope: unit, runner: linux-amd64-2gpu }
-          - { name: mypy, test-scope: mypy, runner: 'linux-amd64-gpu-v100-latest-1' }
+          - { name: pytest, test-scope: test, runner: linux-amd64-gpu-v100-latest-1 }
+          - { name: pytest, test-scope: test, runner: linux-amd64-2gpu }
+          - { name: mypy, test-scope: type-check, runner: linux-amd64-gpu-v100-latest-1 }
     name: ${{ matrix.name }}
-    uses:
-      ./.github/workflows/gh-test.yml
+    secrets: inherit
+    uses: ./.github/workflows/gh-test.yml
     with:
       build-target: gpu
       runs-on: ${{ matrix.runner }}
       sha: ${{ github.sha }}
+      test-name: ${{ matrix.name }}
       test-scope: ${{ matrix.test-scope }}
 
   cleanup:
@@ -45,8 +54,8 @@ jobs:
       - test-gpu
     # This ensures the cleanup job runs even if previous jobs fail or the workflow is cancelled.
     if: always()
-    uses:
-      ./.github/workflows/gh-cleanup.yml
+    secrets: inherit
+    uses: ./.github/workflows/gh-cleanup.yml
     with:
       build-target: gpu
       sha: ${{ github.sha }}

.github/workflows/filter-by-triggering-event.yml

@@ -0,0 +1,30 @@
+name: Filter by triggering event
+
+on:
+  workflow_call:
+    outputs:
+      ok:
+        value: ${{ jobs.filter-by-triggering-event.outputs.ok }}
+
+jobs:
+  filter-by-triggering-event:
+    name: Filter by triggering event
+    runs-on: ubuntu-latest
+    outputs:
+      ok: ${{ steps.filter-by-triggering-event.outputs.ok }}
+    steps:
+      - id: filter-by-triggering-event
+        name: Filter by triggering event
+        shell: bash
+        run: |
+          ###
+          # 1. If `event_name == 'push'` and the repo is the official nv-legate repo.
+          # 2. If `event_name == 'pull_request'` and teh repo is a fork of the official nv-legate repo.
+          ###
+
+          if [[ '${{ github.event_name }}' == 'push' && '${{ github.repository }}' == 'nv-legate/legate.core' ]] \
+          || [[ '${{ github.event_name }}' == 'pull_request' && '${{ github.repository }}' != 'nv-legate/legate.core' ]]; then
+            echo "ok=true"  | tee -a "${GITHUB_OUTPUT}";
+          else
+            echo "ok=false" | tee -a "${GITHUB_OUTPUT}";
+          fi

.github/workflows/gh-build.yml

@@ -14,9 +14,8 @@ on:
         type: string
 
 env:
-  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  BASE_IMAGE: rapidsai/devcontainers:23.06-cpp-cuda11.8-mambaforge-ubuntu22.04
-  IMAGE_NAME: legate.core-${{ inputs.build-target }}
+  BASE_IMAGE: rapidsai/devcontainers:23.10-cpp-cuda11.8-mambaforge-ubuntu22.04
+  IMAGE_TAG: "legate.core-${{ inputs.build-target }}:${{ inputs.sha }}"
   USE_CUDA: ${{ (inputs.build-target == 'cpu' && 'OFF') || 'ON' }}
 
 jobs:
@@ -35,6 +34,8 @@ jobs:
         uses: actions/checkout@v3
         with:
           fetch-depth: 0
+          persist-credentials: false
+          ref: ${{ inputs.sha }}
 
       - if: github.repository_owner == 'nv-legate'
         name: Get AWS credentials for sccache bucket
@@ -50,11 +51,11 @@ jobs:
           docker system prune --all --force
 
       - name: Build docker image
+        env:
+          GH_TOKEN: "${{ secrets.PERSONAL_ACCESS_TOKEN || secrets.GITHUB_TOKEN }}"
         run: |
           echo BUILD_TARGET: ${{ inputs.build-target }}
-          echo USE_CUDA: ${{ env.USE_CUDA }}
-
-          IMAGE_TAG=${{ env.IMAGE_NAME }}:${{ inputs.sha }}
+          echo USE_CUDA: ${USE_CUDA}
 
           continuous_integration/build-docker-image \
             --base-image "$BASE_IMAGE" \
@@ -63,20 +64,17 @@ jobs:
 
       - name: Dump docker history of image before upload
         run: |
-          IMAGE_TAG=${{ env.IMAGE_NAME }}:${{ inputs.sha }}
           docker history $IMAGE_TAG
 
-      - name: Dump docker history of image before upload
-        run: |
-          IMAGE_TAG=${{ env.IMAGE_NAME_CUNUMERIC }}:${{ inputs.sha }}
-
-      - name: Log in to container image registry
-        run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u $ --password-stdin
+      - name: Login to GitHub Container Registry
+        uses: docker/login-action@v2
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Push image
         run: |
-          IMAGE_TAG=${{ env.IMAGE_NAME }}:${{ inputs.sha }}
-
           IMAGE_ID=ghcr.io/${{ github.repository_owner }}
 
           # Change all uppercase to lowercase
@@ -89,10 +87,10 @@ jobs:
 
       - name: Copy artifacts back to the host
         run: |
-          IMAGE_TAG=${{ env.IMAGE_NAME }}:${{ inputs.sha }}
-          mkdir -p artifacts
-          docker run  -v "$(pwd)/artifacts:/home/coder/.artifacts" --rm -t $IMAGE_TAG copy-artifacts
-
+          mkdir -p out;
+          docker run -v "$(pwd)/out:/out" --rm -t -u root $IMAGE_TAG \
+          sh -c "cp -ar /home/coder/.artifacts /out/ && chown -R $(id -u):$(id -g) /out";
+          mv out/.artifacts artifacts && rmdir out;
 
       - name: Display structure of workdir
         run: ls -R

.github/workflows/gh-test.yml

@@ -12,6 +12,9 @@ on:
       sha:
         required: true
         type: string
+      test-name:
+        required: true
+        type: string
       test-scope:
         required: true
         type: string
@@ -33,6 +36,6 @@ jobs:
         name: Run nvidia-smi to make sure GPU is working
         run: nvidia-smi
 
-      - name: Run legate.core test / analysis
+      - name: Run ${{ inputs.test-name }} on legate.core
         shell: su coder {0}
-        run: run-test-or-analysis ${{ inputs.test-scope }}
+        run: ${{ inputs.test-scope }}-legate-python

.gitignore

@@ -30,6 +30,7 @@ config.mk
 /docs/legate/core/build
 /docs/legate/core/source/api/generated
 *.egg-info
+.creds
 .cache
 .coverage
 .vscode