GH, docker based (reusable) workflows#788
GH, docker based (reusable) workflows#788sandeepd-nv merged 99 commits intonv-legate:branch-23.07from
Conversation
sandeepd-nv
added
in progress
category:task
trxcllnt
left a comment
trxcllnt
left a comment
There was a problem hiding this comment.
- The PR injects secrets as build args, which implicitly embeds them in the final image history. Please mount them as docker secrets instead.
- Pulling large image layers from
ghcr.iois very slow unless on a network internal to GitHub. - I've fixed a bunch of things in PR #725, and also have upstream fixes in the 23.08 base images. We should coordinate on merging those first, because they should simplify much of this PR.
sandeepd-nv
force-pushed
the
gh_docker_reusable
branch
from
0f5cd52 to
add605c
Compare
…redentials action.
… a modified copy in the hopes of making the docker based CI work with the configure-aws-credentials GH action.
…nd test were using the same image. Testing a cleanup step using the CPU workflow.
sandeepd-nv
force-pushed
the
gh_docker_reusable
branch
from
5d970e3 to
b3d2f21
Compare
…DEFAULT_CONDA_ENV=legate from the test environment since we need to create the test environment in run-all-tests.
…/test jobs fail.
There was a problem hiding this comment.
Spacing and capitalization nits. The naming of the scripts and the functions in the scripts will cause confusion further down the line if there are repeats and if the only difference is - vs _
Consider creating a conda-management-utils file to host all your utility functions and use arguments on your functions
edit: also indentation nits, we should be consistent in the two space indent
| case "$1" in | ||
| "unit") | ||
| echo "Executing unit tests..." | ||
| mamba install -y -n "${DEFAULT_CONDA_ENV:-legate}" -c conda-forge pytest pytest-mock ipython jupyter_client |
There was a problem hiding this comment.
at some point we should figure out why we can't use the base environment, but this is ok for now
continuous_integration/home/coder/.local/bin/run-test-or-analysis
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,43 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| make_conda_env() { | |||
There was a problem hiding this comment.
Careful about naming. You have a make_conda_env in this file, then you have a make_conda_env in make-conda-env
|
@sandeepd-nv what would be the retention period of images on ghcr.io? |
|
LGTM, please submit when able. |
3 participants
No description provided.