Make ghci parts reusable from cunumeric#796
Make ghci parts reusable from cunumeric#796sandeepd-nv merged 20 commits intonv-legate:branch-23.09from
Conversation
sandeepd-nv
added
in progress
category:task
sandeepd-nv
force-pushed
the
make_ghci_parts_reusable_from_cunumeric
branch
from
eb58290 to
f258a33
Compare
|
|
||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| BASE_IMAGE: rapidsai/devcontainers:23.06-cpp-cuda11.8-mambaforge-ubuntu22.04 |
There was a problem hiding this comment.
We should probably update this to 23.08 version of the devcontainer. Not sure if we should do it here right now or in a separate PR.
There was a problem hiding this comment.
Let's do it in a separate PR.
There was a problem hiding this comment.
Separate PR would be ideal. Keeping conversation open so we don't forget to do this later.
| sleep 10; | ||
| . devcontainer-utils-vault-s3-test; | ||
| . devcontainer-utils-vault-s3-export 0; | ||
| } |
There was a problem hiding this comment.
My understanding of this is lacking. :) Why do we need this?
There was a problem hiding this comment.
devcontainer-utils-vault-s3-test
This tests if AWS credentials are valid.
devcontainer-utils-vault-s3-export
This sets up various SCCACHE_* env vars through ~/.aws/config or ~/.bashrc.
These things are required for enabling SCCACHE for "local repro" where AWS auth happens using a GH personal access token.
There was a problem hiding this comment.
I would also add that the 10 second wait is essential. The credentials that we get are generated on the fly, and need to be uploaded to AWS. We hit authentication issues if we try to race against the upload process.
There was a problem hiding this comment.
This is also done in the 23.08 devcontainers (and removed in #725).
…named build-all to build-legate-all.
sandeepd-nv
force-pushed
the
make_ghci_parts_reusable_from_cunumeric
branch
from
caefe9d to
b70e06c
Compare
m3vaz
left a comment
m3vaz
left a comment
There was a problem hiding this comment.
We should file an issue on github tracking the numpy discrepancy (i.e. the reason why we need the WAR) and reference the issue number in the WAR comment, but otherwise LGTM
4 participants
No description provided.