Use Legion with CMake's native CUDA language#828
Merged
manopapad merged 10 commits intonv-legate:branch-23.09from Sep 1, 2023
Merged
Use Legion with CMake's native CUDA language#828manopapad merged 10 commits intonv-legate:branch-23.09from
manopapad merged 10 commits intonv-legate:branch-23.09from
Conversation
magnatelee
added
the
category:improvement
…ode with build isolation, fix legion python installs for both editable and non-editable modes
Contributor
Contributor
Author
|
/ok to test |
for more information, see https://pre-commit.ci
trxcllnt
force-pushed
the
fix/legion-cmake-cuda-update
branch
from
119508e to
e947e42
Compare
manopapad
reviewed
Aug 31, 2023
Contributor
|
@trxcllnt If not already, can you also add a CI job(s) that tests the editable install + venv in this PR? |
Contributor
Author
|
@Jacobfaib That's going to be a bit of a stretch, as this PR is rather urgent to unblock folks who need to use the latest |
manopapad
approved these changes
Sep 1, 2023
This was referenced Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of #725 that touches fewer CI-related files. Updates Legion to the commit hash in #827.