Follow up of #14503: Move extension points to top level module and fix FilterValueT name#14549
Merged
Merged
Conversation
seanbudd
approved these changes
Jan 16, 2023
See test results for failed build of commit 7334a18bd2 |
See test results for failed build of commit da3e382f47 |
ctoth
pushed a commit
to NVDARemote/NVDARemote
that referenced
this pull request
Mar 4, 2023
* Support NVDA 2023.1 * fix nvaccess/nvda#14549 * Forgotten unregister * Support isSpeechBeepCommand kwarg * Bump buildVars and ensure decide_enabled is on local machine * Use terminate func on loacl_machine instead * No longer cleanup cursor blink timer because NVDA core is responsible for that * Bad copy paste fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#14531 (comment)
Summary of the issue:
Description of user facing changes
Moved extension points, changes file is changed as part of this pr to reflect this.
Description of development approach
Just moving and renaming code
Testing strategy:
Unit tests should cover this, I manually tested the braille viewer.
Known issues with pull request:
None known
Change log entries:
In PR diff
Code Review Checklist: