Skip to content

Follow up of #14503: Move extension points to top level module and fix FilterValueT name#14549

Merged
seanbudd merged 7 commits into
nvaccess:masterfrom
LeonarddeR:fixFilterValueT
Jan 16, 2023
Merged

Follow up of #14503: Move extension points to top level module and fix FilterValueT name#14549
seanbudd merged 7 commits into
nvaccess:masterfrom
LeonarddeR:fixFilterValueT

Conversation

@LeonarddeR
Copy link
Copy Markdown
Collaborator

Link to issue number:

#14531 (comment)

Summary of the issue:

  1. FilterValueTypeT nneeded renaming to FilterValueT and had a wrong string in its TypeVar declaration.
  2. When experimenting with the extensionPoints, particularlyy with registering a handler to decide_executeGesture in a braille display driver, I discovered that inputCore was not yet initialized when initializing the driver and therefore extension point registration failed.

Description of user facing changes

Moved extension points, changes file is changed as part of this pr to reflect this.

Description of development approach

Just moving and renaming code

Testing strategy:

Unit tests should cover this, I manually tested the braille viewer.

Known issues with pull request:

None known

Change log entries:

In PR diff

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@LeonarddeR LeonarddeR requested a review from a team as a code owner January 16, 2023 07:41
@LeonarddeR LeonarddeR requested a review from seanbudd January 16, 2023 07:41
@LeonarddeR LeonarddeR added this to the 2023.1 milestone Jan 16, 2023
@AppVeyorBot
Copy link
Copy Markdown

See test results for failed build of commit 7334a18bd2

@AppVeyorBot
Copy link
Copy Markdown

  • PASS: Translation comments check.
  • PASS: Unit tests.
  • PASS: Lint check.
  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit da3e382f47

@seanbudd seanbudd merged commit e16c310 into nvaccess:master Jan 16, 2023
ctoth pushed a commit to NVDARemote/NVDARemote that referenced this pull request Mar 4, 2023
* Support NVDA 2023.1

* fix nvaccess/nvda#14549

* Forgotten unregister

* Support isSpeechBeepCommand kwarg

* Bump buildVars and ensure decide_enabled is on local machine

* Use terminate func on loacl_machine instead

* No longer cleanup cursor blink timer because NVDA core is responsible for that

* Bad copy paste fix
@LeonarddeR LeonarddeR deleted the fixFilterValueT branch August 23, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants