Add new extension points for keyboard input and speech pause#17428
Conversation
- Add type annotations to decide_handleRawKey extension point parameters - Rename speechPaused to post_speechPaused to follow coding standards for post-event naming - Add PR reference (nvaccess#17428) to changelog entry - Format extension point names in changelog with backticks
|
Does this close #14520? |
- Add decide_handleRawKey extension point to allow intercepting raw keyboard events - Add speechPaused extension point for speech pause/resume notifications - Update documentation to reflect new extension points - Add unit tests for speechPaused extension point
- Add type annotations to decide_handleRawKey extension point parameters - Rename speechPaused to post_speechPaused to follow coding standards for post-event naming - Add PR reference (nvaccess#17428) to changelog entry - Format extension point names in changelog with backticks
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
f2db892 to
836de54
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Is this PR triggered by the need to remove monkey patching in NVDA remote? |
|
Just to say that I'plan to use the keyboard extension point in the pcKbBrl add-on. Thanks for this PR. Hope this is merged when possible to test it. |
See test results for failed build of commit 2777ea2c3c |
|
@seanbudd Re #14520 we still need one more extension point for speech either directly inside or directly before Unfortunately existing Remote monkeypatches |
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
Add new extension points for raw keyboard events and speech pause state
This commit introduces two new extension points:
Technical Details:
These additions enable add-ons to:
Link to issue number:
N/A - New feature addition for extensibility
Summary of the issue:
NVDA needed additional extension points to allow add-ons to:
Description of user facing changes
Description of development approach
Raw Keyboard Extension Point:
decide_handleRawKeyextension point in inputCore.pySpeech Pause Extension Point:
speechPausedextension point in speech/extensions.pyDocumentation:
Testing strategy:
Unit Tests:
Manual Testing:
Known issues with pull request:
None identified - straightforward API additions with full test coverage
Code Review Checklist:
Documentation:
Testing:
UX of all users considered:
API is compatible with existing add-ons
Security precautions taken:
@coderabbitai summary