Skip to content

Conversation

@theopn
Copy link
Contributor

@theopn theopn commented Mar 29, 2025

                                          *grr* *gra* *grn* *gri* *i_CTRL-S*
Some keymaps are created unconditionally when Nvim starts:
- "grn" is mapped in Normal mode to |vim.lsp.buf.rename()|
- "gra" is mapped in Normal and Visual mode to |vim.lsp.buf.code_action()|
- "grr" is mapped in Normal mode to |vim.lsp.buf.references()|
- "gri" is mapped in Normal mode to |vim.lsp.buf.implementation()|
- "gO" is mapped in Normal mode to |vim.lsp.buf.document_symbol()|
- CTRL-S is mapped in Insert mode to |vim.lsp.buf.signature_help()|

Neovim 0.11 introduced many default LSP keybindings prefixed with gr, and this PR changes the Telescope keybindings defined in LspAttach autocmds to match the default ones.

I think changing other keybindings (<leader>D for type definition and <leader>ws for workspace symbols) to have g prefix should also be considered.

@arerossehaug
Copy link

Any reason to choose gca over gra for code actions?
While the [G]oto [C]ode [A]ction makes more sense than [G]oto [R]? [A]ction, the gra is a smoother key combination in my opinion

Semi related, but should it be considered that gd (goto definition) should become grd?

@theopn
Copy link
Contributor Author

theopn commented Mar 31, 2025

@arerossehaug 😅 just a typo, I amended it to be gra. My idea was to follow the default keybindings provided by Neovim to minimize the confusion.

I have also added a commit for changing the other keybindings, prefixing gr for "Goto" and g for opening a list of symbols:

  • gd -> grd for goto definition
  • gD -> grD for goto declaration
  • <leader>D -> grt for type definition
  • <leader>w -> gW for workspace symbols

@feoh
Copy link
Collaborator

feoh commented Apr 9, 2025

I have no feelings about this, but making changes to key bindings always ends up with a million angry WHY DID YOU MOVE MY CHEESE? comments.

Thoughts from everyone?

@theopn
Copy link
Contributor Author

theopn commented Apr 9, 2025

@feoh I agree that changing keybindings can cause confusion, but I have two arguments for this particular changes:

  1. some existing keybindings (e.g., gr for LSP references) conflicts with the new default keybindings in 0.11, so we need to either delete the default keybindings or change our keybindings; see [Suggestion] default lsp key mappings in neovim v0.11.0 will interfere existing key mappings in lspconfig #1436
  2. these are the default keybindings that Neovim will use moving forward, and considering the demographics of people using Kickstart (lots of beginners and new to configuring Neovim) and how they use Kickstart (use to build their own config), I think it is important to let them know that default keybindings for such and such actions exist.

Thoughts?

@chrstief
Copy link

chrstief commented Apr 9, 2025

If the kickstart project was started today, they would go with the default nvim keybinds. I’m in support of this change, instead of sticking to non default keybinds for historic reasons.

@feoh
Copy link
Collaborator

feoh commented Apr 9, 2025

Two people voting yay is enough for me :) Thanks all! merging.

@feoh feoh merged commit 1a5787b into nvim-lua:master Apr 9, 2025
1 check passed
dribic pushed a commit to dribic/nvim-files that referenced this pull request Apr 9, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
fluxth added a commit to fluxth/nvim-config that referenced this pull request Apr 10, 2025
…roduced in Neovim 0.11 (nvim-lua#1427)"

This reverts commit 1a5787b.

I'm not in the mood to learn new keybindings right now.
Will do it in my own time.
fluxth added a commit to fluxth/nvim-config that referenced this pull request Apr 10, 2025
…roduced in Neovim 0.11 (nvim-lua#1427)"

This reverts commit 1a5787b.

I'm not in the mood to learn new keybindings right now.
Will do it in my own time.
dimitrov-anasoft pushed a commit to dimitrov-anasoft/kickstart.nvim that referenced this pull request Apr 10, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
@5brian
Copy link

5brian commented Apr 11, 2025

Sorry to necro this, would a pr to add the few leader key bindings back in comments be accepted?

For example:


-- If you prefer the legacy <leader> keymaps,
-- you can uncomment the following lines

faizfrhn added a commit to faizfrhn/kickstart.nvim that referenced this pull request Apr 11, 2025
* Change LSP Keybindings to Match the Default gr Bindings Introduced in Neovim 0.11 (nvim-lua#1427)
* Remove Telescope 0.1 branch lock (nvim-lua#1448)
vencronys pushed a commit to vencronys/kickstart.nvim that referenced this pull request Apr 12, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
DerFrZocker pushed a commit to DerFrZocker/.dotfiles-nvim that referenced this pull request Apr 12, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
vizzersrc pushed a commit to vizzersrc/vizzer.nvim that referenced this pull request Apr 13, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
Jidou pushed a commit to Jidou/kickstart.nvim that referenced this pull request Apr 14, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
mascanio pushed a commit to mascanio/kickstart.nvim that referenced this pull request Apr 17, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
chrisBosse pushed a commit to chrisBosse/kickstart.nvim that referenced this pull request Apr 17, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
tsaeger added a commit to tsaeger/dotvim that referenced this pull request Apr 18, 2025
Use same keymaps as 0.11:

nvim-lua/kickstart.nvim#1427

Signed-off-by: Tom Saeger <tom.saeger@gmail.com>
nickgnd added a commit to nickgnd/kickstart.nvim that referenced this pull request Apr 21, 2025
mirite pushed a commit to mirite/kickstart.nvim that referenced this pull request Apr 22, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
vantmet pushed a commit to vantmet/kickstart.nvim that referenced this pull request Apr 24, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
Shadowmeister pushed a commit to Shadowmeister/nvim that referenced this pull request Apr 27, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
nogurenn pushed a commit to nogurenn/kickstart.nvim that referenced this pull request Apr 27, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
GabrielTorland pushed a commit to GabrielTorland/kickstart.nvim that referenced this pull request Apr 27, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
eduardofuncao pushed a commit to eduardofuncao/config.nvim that referenced this pull request Aug 5, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
adityaravichandran6 added a commit to adityaravichandran6/mazov.nvim that referenced this pull request Aug 7, 2025
* fix: minor misspellings (nvim-lua#1450)

* fix: minor misspellings

* revert change for `-Bbuild`

* Change LSP Keybindings to Match the Default `gr` Bindings Introduced in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention

* Remove Telescope `0.1` branch lock (nvim-lua#1448)

* feat: switch nvim-cmp for blink.cmp (nvim-lua#1426)

* Change to Mason's new address (nvim-lua#1516)

* feat: switch vim-sleuth for guess-indent.nvim (nvim-lua#1512)

* Replace vim.opt with vim.o (nvim-lua#1495)

* Replace vim.opt with vim.o

Because it offers a nicer interface and info on hover.
For now leave vim.opt when using the table interface (until vim.o
with tables is implemented)

* Add type hint for vim.opt.rtp

* Add a comment about using vim.opt instead of vim.o

* don't lazy-load neo-tree so netrw hijacking on startup works (nvim-lua#1489)

* README: mention fd-find in requirements (nvim-lua#1477)

Fixes nvim-lua#1476

* fix: rename vim.highlight.on_yank to vim.hl.on_yank (nvim-lua#1482)

The functions of vim.highlight were renamed to vim.hl on commit
18b43c331d8a0ed87d7cbefe2a18543b8e4ad360 of neovim, which was applied
with the release of nvim version 0.11.

Now, the use of vim.highlight is deprecated, and instead, one should
use vim.hl functions.
In practice, vim.highlight is still working, however, asking for help
for vim.highlight.on_yank fails (E149), while asking for help for
vim.hl.on_yank works as expected. So, by updating the used function, a
new user will have easier time looking getting the relevant help.

Co-authored-by: Omri Sarig <omri.sarig@prevas.dk>

* Update remaining Mason's old address (nvim-lua#1530)

* Initial plugin setup (#1)

This adds a basic layer of plugins. But more language and workflow specific plugins are to follow possibly.

---------

Co-authored-by: dasvh <dasvh@protonmail.com>
Co-authored-by: Theo P. <63016528+theopn@users.noreply.github.com>
Co-authored-by: Dmytro Onypko <vaporif@gmail.com>
Co-authored-by: Liam Dyer <liamcdyer@gmail.com>
Co-authored-by: guru245 <guru245@users.noreply.github.com>
Co-authored-by: Ori Perry <48057913+oriori1703@users.noreply.github.com>
Co-authored-by: pynappo <lehtien.david@gmail.com>
Co-authored-by: Damjan 9000 <damjan.9000@gmail.com>
Co-authored-by: Omri Sarig <omri.sarig13@gmail.com>
Co-authored-by: Omri Sarig <omri.sarig@prevas.dk>
Co-authored-by: Carlos Calla Alarcón <calla.alarcon@gmail.com>
devloglogan pushed a commit to devloglogan/kickstart.nvim that referenced this pull request Aug 11, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
alex-rieger pushed a commit to alex-rieger/kickstart.nvim that referenced this pull request Aug 17, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
k7o pushed a commit to k7o/kickstart.nvim that referenced this pull request Aug 18, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
benfleuty pushed a commit to benfleuty/kickstart.nvim that referenced this pull request Aug 19, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
LoganSchmalz pushed a commit to LoganSchmalz/kickstart.nvim that referenced this pull request Aug 21, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
ncason pushed a commit to ncason/kickstart.nvim that referenced this pull request Aug 23, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
nrhooks17 pushed a commit to nrhooks17/central-nvim that referenced this pull request Aug 26, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
sooren-ghodsi pushed a commit to sooren-ghodsi/kickstart.nvim that referenced this pull request Aug 26, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
2takker pushed a commit to 2takker/kickstart.nvim that referenced this pull request Sep 2, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
Gugfann pushed a commit to Gugfann/kickstart.nvim that referenced this pull request Oct 10, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
juantot9 pushed a commit to juantot9/kickstart.nvim that referenced this pull request Oct 20, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
hangtaip pushed a commit to hangtaip/kickstart.nvim that referenced this pull request Oct 20, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
andreacanton pushed a commit to andreacanton/kickstart.nvim that referenced this pull request Oct 21, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
andeem pushed a commit to andeem/kickstart.nvim that referenced this pull request Oct 31, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
cezary17 pushed a commit to cezary17/kickstart.nvim that referenced this pull request Nov 4, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
marcinburzynski pushed a commit to marcinburzynski/nvim.config that referenced this pull request Nov 7, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
marcinburzynski pushed a commit to marcinburzynski/nvim.config that referenced this pull request Nov 7, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
fardente pushed a commit to fardente/kickstart.nvim that referenced this pull request Nov 7, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
bad-rooster added a commit to bad-rooster/kickstart.nvim that referenced this pull request Nov 19, 2025
* feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define() (nvim-lua#1232)

* Fix nvim-dap not lazy loading (nvim-lua#1216)

* Fix nvim-dap not lazy loading

The keys property had local variables 'dap' and 'dap-ui' that used `require` and prevented all DAP related plugins from lazy-loading.
Fixed this by changing keys to a table and substituting the local variables with a lamba function

* Make debug keybind descriptions more consistent

* fix: which-key comment typo (nvim-lua#1227)

* Tweak outdated comment about lazy's `config` key usage. (nvim-lua#1250)

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* Use consistent syntax style for { ... } "pseudocode" (nvim-lua#1247)

```
require('gitsigns').setup({ ... })
```

This was the first occurrence

It may be nice to have the same style everywhere

Cosmetic change (just to make docs/comments even more perfect)

* Issue 1249  which key comments (nvim-lua#1263)

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

* fix(gitsigns): make visual mode descriptions consistent with normal mode (nvim-lua#1266)

* Fix README.md grammar and  typos (nvim-lua#1291)

* chore: add pre-issue requirements (nvim-lua#1288)

* chore: add pre-issue requirements

Based on nvim-lua#1285

* docs: add header about documentation

Based on nvim-lua#1285

* Fix which-key delay settings (nvim-lua#1276)

The which-key plugin used to rely on vim.opt.timeoutlen, but it was
updated a few months ago to use its own opt.delay instead.

https://github.com/folke/which-key.nvim/blob/8ab96b38a2530eacba5be717f52e04601eb59326/NEWS.md?plain=1#L10

I set which-key's delay to 0 ms because it makes it feel snappy and
responsive! That way, we give new users a good first impression.

* fix: prevent mason setup from being run twice (nvim-lua#1298)

* fix: prevent mason setup from being run twice

Addresses nvim-lua#1297

Currently, we're calling `require('mason').setup(...)` twice:
* once when setting it as a dependency of `nvim-lspconfig` (since we set
	`config = true`)
* once in the `config` function we define for `nvim-lspconfig`

Calling setup twice can cause issues with, e.g., setting the `PATH`
option: you might append Mason's bin dir in one setup call and prepend
it in the other.

We've kept the setup of `mason` in the `nvim-lspconfig` dependencies
table since leaving it to the `config` function caused some
plugin-loading-order related issues in the past. See:
* nvim-lua#210
* nvim-lua#554
* nvim-lua#555
* nvim-lua#865

* docs: tweak comments per review feedback

* chore: remove redundant comment (nvim-lua#1307)

* chore: fix typo in bug report issue template (nvim-lua#1306)

* Use luals 3rd library for luv (nvim-lua#1303)

* chore(docs): Update README.md (nvim-lua#1344)

Neovim has renamed the "linux64" binary to "linux-x86_64".

* docs: clarify using opts = {} vs config = function() ... require('plu… (nvim-lua#1316)

* docs: clarify using opts = {} vs config = function() ... require('plugin').setup({}) .. end

The current documentation mentioning that using "require" is equivalent to using "opts" without detailing the use in the "config = function()" block seems inaccurate.
Lower in the configuration the "config = function()" block is used without clarifying why it needed and what it does.
This clarification may help new users understand the difference between the two, or how and where to place the "require" statement.

* Update init.lua

* remove whitespace

* fix (nvim-lua#1319): gitsigns deprecated functions (nvim-lua#1321)

- This commit change two functions that are marked as deprecated now:
`gitsigns.stage_hunk` and `gitsigns.toggle_deleted`

* Add a blurb about installing missing emoji on Ubuntu

Right next to the nerdfonts blurb as requested.

* fix: arguments for the `vim.lsp.Client.supports_method` method (nvim-lua#1356)

* feat(diagnostic): add diagnostic config (nvim-lua#1335)

Co-authored-by: gelocraft <gelocraft@users.noreply.github.com>

* perf: load tokyonight.nvim in the intended way (nvim-lua#1360)

Fixes nvim-lua#1357

* feat: add basic function signature help (nvim-lua#1358)

* feat: add basic function signature help

* Update init.lua

Co-authored-by: makeworld <25111343+makew0rld@users.noreply.github.com>

---------

Co-authored-by: makeworld <25111343+makew0rld@users.noreply.github.com>

* Fix: fix the cmp-nvim-lsp-signature-help link (nvim-lua#1363)

* fix: regression introduced in db78c0b (nvim-lua#1367)

* Remove duplicate cmp-path (nvim-lua#1369)

* Propsed fix for init.lua warnings as per nvim-lua#1305 (comment) (nvim-lua#1354)

* feat: add `vim.opt.confirm = true` (nvim-lua#1384)

* fix: use correct github abmonition syntax (nvim-lua#1414)

* changed Conform's format_on_save lambda so that buffers that match disable_filetypes return nil. This allows you to enable a formatter for langages in the disable_filetypes table to have a formatter that can be run manually with Leader-f but doesnt enable format_on_save for them (nvim-lua#1395)

* feat(keymap): move windows without `<C-w>` (nvim-lua#1368)

* fix: minor misspellings (nvim-lua#1450)

* fix: minor misspellings

* revert change for `-Bbuild`

* Change LSP Keybindings to Match the Default `gr` Bindings Introduced in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention

* Remove Telescope `0.1` branch lock (nvim-lua#1448)

* feat: switch nvim-cmp for blink.cmp (nvim-lua#1426)

* Change to Mason's new address (nvim-lua#1516)

* feat: switch vim-sleuth for guess-indent.nvim (nvim-lua#1512)

* Replace vim.opt with vim.o (nvim-lua#1495)

* Replace vim.opt with vim.o

Because it offers a nicer interface and info on hover.
For now leave vim.opt when using the table interface (until vim.o
with tables is implemented)

* Add type hint for vim.opt.rtp

* Add a comment about using vim.opt instead of vim.o

* don't lazy-load neo-tree so netrw hijacking on startup works (nvim-lua#1489)

* README: mention fd-find in requirements (nvim-lua#1477)

Fixes nvim-lua#1476

* fix: rename vim.highlight.on_yank to vim.hl.on_yank (nvim-lua#1482)

The functions of vim.highlight were renamed to vim.hl on commit
18b43c331d8a0ed87d7cbefe2a18543b8e4ad360 of neovim, which was applied
with the release of nvim version 0.11.

Now, the use of vim.highlight is deprecated, and instead, one should
use vim.hl functions.
In practice, vim.highlight is still working, however, asking for help
for vim.highlight.on_yank fails (E149), while asking for help for
vim.hl.on_yank works as expected. So, by updating the used function, a
new user will have easier time looking getting the relevant help.

Co-authored-by: Omri Sarig <omri.sarig@prevas.dk>

* Update remaining Mason's old address (nvim-lua#1530)

---------

Co-authored-by: gloomy-lemon-debatable <91877885+gloomy-lemon-debatable@users.noreply.github.com>
Co-authored-by: Anjishnu Banerjee <107052359+kaezrr@users.noreply.github.com>
Co-authored-by: Miha <79801427+mihasket@users.noreply.github.com>
Co-authored-by: ben fleis <benfleis@users.noreply.github.com>
Co-authored-by: Artem Dragunov <dragunovartem99@gmail.com>
Co-authored-by: Scott Swensen <git@scottswensen.com>
Co-authored-by: George <george@primalskill.com>
Co-authored-by: Ihsan Tonuzi <115842560+iton0@users.noreply.github.com>
Co-authored-by: Ryan Jensen <jensenr30@gmail.com>
Co-authored-by: Tomas Gareau <tggareau@gmail.com>
Co-authored-by: Nhan Luu <62146587+nhld@users.noreply.github.com>
Co-authored-by: Diorman Colmenares <229201+diorman@users.noreply.github.com>
Co-authored-by: Ryan Nevius <rnevius@users.noreply.github.com>
Co-authored-by: bleacheda <60625523+bleacheda@users.noreply.github.com>
Co-authored-by: Erlan Rangel <erlanrangel@gmail.com>
Co-authored-by: Chris Patti <feoh@feoh.org>
Co-authored-by: Jonas Zeltner <jonas.zeltner@posteo.de>
Co-authored-by: GeloCraft <115651305+gelocraft@users.noreply.github.com>
Co-authored-by: gelocraft <gelocraft@users.noreply.github.com>
Co-authored-by: Joaquín Guerra <joaquinguerratocino@gmail.com>
Co-authored-by: Rob <rcsfletcher@protonmail.com>
Co-authored-by: makeworld <25111343+makew0rld@users.noreply.github.com>
Co-authored-by: Aryan Rajoria <57455619+aryan-rajoria@users.noreply.github.com>
Co-authored-by: Ari Pollak <aripollak@users.noreply.github.com>
Co-authored-by: Crypto-Spartan <29098151+Crypto-Spartan@users.noreply.github.com>
Co-authored-by: Luca Saccarola <96259932+saccarosium@users.noreply.github.com>
Co-authored-by: RulentWave <49258216+RulentWave@users.noreply.github.com>
Co-authored-by: Sander <info@mesander.com>
Co-authored-by: dasvh <dasvh@protonmail.com>
Co-authored-by: Theo P. <63016528+theopn@users.noreply.github.com>
Co-authored-by: Dmytro Onypko <vaporif@gmail.com>
Co-authored-by: Liam Dyer <liamcdyer@gmail.com>
Co-authored-by: guru245 <guru245@users.noreply.github.com>
Co-authored-by: Ori Perry <48057913+oriori1703@users.noreply.github.com>
Co-authored-by: pynappo <lehtien.david@gmail.com>
Co-authored-by: Damjan 9000 <damjan.9000@gmail.com>
Co-authored-by: Omri Sarig <omri.sarig13@gmail.com>
Co-authored-by: Omri Sarig <omri.sarig@prevas.dk>
Co-authored-by: Carlos Calla Alarcón <calla.alarcon@gmail.com>
timhammond pushed a commit to timhammond/kickstart.nvim that referenced this pull request Nov 21, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
@moustario moustario mentioned this pull request Dec 3, 2025
bruyss pushed a commit to bruyss/nvim-lua that referenced this pull request Dec 6, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
anyangateny1 pushed a commit to anyangateny1/.dotfiles that referenced this pull request Dec 20, 2025
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
5p1n0 added a commit to 5p1n0/kickstart.nvim that referenced this pull request Dec 28, 2025
* fix: update lazy uninstall information link (nvim-lua#1148)

* Disable linting autocmd for readonly buffers (nvim-lua#1202)

* Disable linting autocmd for readonly buffers

This should avoid linting in buffers outside of the user's control,
having in mind especially the handy LSP pop-ups that describe your
hovered symbol using markdown.

Co-authored-by: Robin Gruyters <2082795+rgruyters@users.noreply.github.com>

* Justify guarding try_lint in readonly buffers

Co-authored-by: Robin Gruyters <2082795+rgruyters@users.noreply.github.com>

---------

Co-authored-by: Robin Gruyters <2082795+rgruyters@users.noreply.github.com>

* samarth-nagar fix: lazy help tag on line 931 (nvim-lua#1167)

* samarth-nagar fix: lazy help tag on line 931

found in issue nvim-lua#1152

* fixed white space

---------

Co-authored-by: sam <110125971+samarth-nagar@users.noreply.github.com>

* Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195)

* feat: Change diagnostic symbols if vim.g.have_nerd_font is true

* feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>

* Set breakpoint icons and their highlight colors (nvim-lua#1194)

* feat: Set breakpoint icons and their highlight colors

* docs: Delete reference URL (written in PR)
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns
feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so

---------

Co-authored-by: name <email>

* Remove two because there are more than two. (nvim-lua#1213)

* feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define() (nvim-lua#1232)

* Fix nvim-dap not lazy loading (nvim-lua#1216)

* Fix nvim-dap not lazy loading

The keys property had local variables 'dap' and 'dap-ui' that used `require` and prevented all DAP related plugins from lazy-loading.
Fixed this by changing keys to a table and substituting the local variables with a lamba function

* Make debug keybind descriptions more consistent

* fix: which-key comment typo (nvim-lua#1227)

* Tweak outdated comment about lazy's `config` key usage. (nvim-lua#1250)

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* Use consistent syntax style for { ... } "pseudocode" (nvim-lua#1247)

```
require('gitsigns').setup({ ... })
```

This was the first occurrence

It may be nice to have the same style everywhere

Cosmetic change (just to make docs/comments even more perfect)

* Issue 1249  which key comments (nvim-lua#1263)

* Tweak outdated comment about lazy's `config` key usage.

Remove outdated comment describing use of `config` key, replacing with
corrected `opt` key note.

Fixes nvim-lua#1249

* fix typo opt -> opts

Fixes nvim-lua#1250

* fix(gitsigns): make visual mode descriptions consistent with normal mode (nvim-lua#1266)

* Fix README.md grammar and  typos (nvim-lua#1291)

* chore: add pre-issue requirements (nvim-lua#1288)

* chore: add pre-issue requirements

Based on nvim-lua#1285

* docs: add header about documentation

Based on nvim-lua#1285

* Fix which-key delay settings (nvim-lua#1276)

The which-key plugin used to rely on vim.opt.timeoutlen, but it was
updated a few months ago to use its own opt.delay instead.

https://github.com/folke/which-key.nvim/blob/8ab96b38a2530eacba5be717f52e04601eb59326/NEWS.md?plain=1#L10

I set which-key's delay to 0 ms because it makes it feel snappy and
responsive! That way, we give new users a good first impression.

* fix: prevent mason setup from being run twice (nvim-lua#1298)

* fix: prevent mason setup from being run twice

Addresses nvim-lua#1297

Currently, we're calling `require('mason').setup(...)` twice:
* once when setting it as a dependency of `nvim-lspconfig` (since we set
	`config = true`)
* once in the `config` function we define for `nvim-lspconfig`

Calling setup twice can cause issues with, e.g., setting the `PATH`
option: you might append Mason's bin dir in one setup call and prepend
it in the other.

We've kept the setup of `mason` in the `nvim-lspconfig` dependencies
table since leaving it to the `config` function caused some
plugin-loading-order related issues in the past. See:
* nvim-lua#210
* nvim-lua#554
* nvim-lua#555
* nvim-lua#865

* docs: tweak comments per review feedback

* chore: remove redundant comment (nvim-lua#1307)

* chore: fix typo in bug report issue template (nvim-lua#1306)

* Use luals 3rd library for luv (nvim-lua#1303)

* chore(docs): Update README.md (nvim-lua#1344)

Neovim has renamed the "linux64" binary to "linux-x86_64".

* docs: clarify using opts = {} vs config = function() ... require('plu… (nvim-lua#1316)

* docs: clarify using opts = {} vs config = function() ... require('plugin').setup({}) .. end

The current documentation mentioning that using "require" is equivalent to using "opts" without detailing the use in the "config = function()" block seems inaccurate.
Lower in the configuration the "config = function()" block is used without clarifying why it needed and what it does.
This clarification may help new users understand the difference between the two, or how and where to place the "require" statement.

* Update init.lua

* remove whitespace

* fix (nvim-lua#1319): gitsigns deprecated functions (nvim-lua#1321)

- This commit change two functions that are marked as deprecated now:
`gitsigns.stage_hunk` and `gitsigns.toggle_deleted`

* Add a blurb about installing missing emoji on Ubuntu

Right next to the nerdfonts blurb as requested.

* fix: arguments for the `vim.lsp.Client.supports_method` method (nvim-lua#1356)

* feat(diagnostic): add diagnostic config (nvim-lua#1335)

Co-authored-by: gelocraft <gelocraft@users.noreply.github.com>

* perf: load tokyonight.nvim in the intended way (nvim-lua#1360)

Fixes nvim-lua#1357

* feat: add basic function signature help (nvim-lua#1358)

* feat: add basic function signature help

* Update init.lua

Co-authored-by: makeworld <25111343+makew0rld@users.noreply.github.com>

---------

Co-authored-by: makeworld <25111343+makew0rld@users.noreply.github.com>

* Fix: fix the cmp-nvim-lsp-signature-help link (nvim-lua#1363)

* fix: regression introduced in db78c0b (nvim-lua#1367)

* Remove duplicate cmp-path (nvim-lua#1369)

* Propsed fix for init.lua warnings as per nvim-lua#1305 (comment) (nvim-lua#1354)

* feat: add `vim.opt.confirm = true` (nvim-lua#1384)

* fix: use correct github abmonition syntax (nvim-lua#1414)

* changed Conform's format_on_save lambda so that buffers that match disable_filetypes return nil. This allows you to enable a formatter for langages in the disable_filetypes table to have a formatter that can be run manually with Leader-f but doesnt enable format_on_save for them (nvim-lua#1395)

* feat(keymap): move windows without `<C-w>` (nvim-lua#1368)

* fix: minor misspellings (nvim-lua#1450)

* fix: minor misspellings

* revert change for `-Bbuild`

* Change LSP Keybindings to Match the Default `gr` Bindings Introduced in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention

* Remove Telescope `0.1` branch lock (nvim-lua#1448)

* feat: switch nvim-cmp for blink.cmp (nvim-lua#1426)

* Change to Mason's new address (nvim-lua#1516)

* feat: switch vim-sleuth for guess-indent.nvim (nvim-lua#1512)

* Replace vim.opt with vim.o (nvim-lua#1495)

* Replace vim.opt with vim.o

Because it offers a nicer interface and info on hover.
For now leave vim.opt when using the table interface (until vim.o
with tables is implemented)

* Add type hint for vim.opt.rtp

* Add a comment about using vim.opt instead of vim.o

* don't lazy-load neo-tree so netrw hijacking on startup works (nvim-lua#1489)

* README: mention fd-find in requirements (nvim-lua#1477)

Fixes nvim-lua#1476

* fix: rename vim.highlight.on_yank to vim.hl.on_yank (nvim-lua#1482)

The functions of vim.highlight were renamed to vim.hl on commit
18b43c331d8a0ed87d7cbefe2a18543b8e4ad360 of neovim, which was applied
with the release of nvim version 0.11.

Now, the use of vim.highlight is deprecated, and instead, one should
use vim.hl functions.
In practice, vim.highlight is still working, however, asking for help
for vim.highlight.on_yank fails (E149), while asking for help for
vim.hl.on_yank works as expected. So, by updating the used function, a
new user will have easier time looking getting the relevant help.

Co-authored-by: Omri Sarig <omri.sarig@prevas.dk>

* Update remaining Mason's old address (nvim-lua#1530)

---------

Co-authored-by: Bastien Traverse <neitsab@esrevart.net>
Co-authored-by: Éric NICOLAS <ccjmne@gmail.com>
Co-authored-by: Robin Gruyters <2082795+rgruyters@users.noreply.github.com>
Co-authored-by: sam <110125971+samarth-na@users.noreply.github.com>
Co-authored-by: sam <110125971+samarth-nagar@users.noreply.github.com>
Co-authored-by: gloomy-lemon-debatable <91877885+gloomy-lemon-debatable@users.noreply.github.com>
Co-authored-by: Will Winder <wwinder.unh@gmail.com>
Co-authored-by: Anjishnu Banerjee <107052359+kaezrr@users.noreply.github.com>
Co-authored-by: Miha <79801427+mihasket@users.noreply.github.com>
Co-authored-by: ben fleis <benfleis@users.noreply.github.com>
Co-authored-by: Artem Dragunov <dragunovartem99@gmail.com>
Co-authored-by: Scott Swensen <git@scottswensen.com>
Co-authored-by: George <george@primalskill.com>
Co-authored-by: Ihsan Tonuzi <115842560+iton0@users.noreply.github.com>
Co-authored-by: Ryan Jensen <jensenr30@gmail.com>
Co-authored-by: Tomas Gareau <tggareau@gmail.com>
Co-authored-by: Nhan Luu <62146587+nhld@users.noreply.github.com>
Co-authored-by: Diorman Colmenares <229201+diorman@users.noreply.github.com>
Co-authored-by: Ryan Nevius <rnevius@users.noreply.github.com>
Co-authored-by: bleacheda <60625523+bleacheda@users.noreply.github.com>
Co-authored-by: Erlan Rangel <erlanrangel@gmail.com>
Co-authored-by: Chris Patti <feoh@feoh.org>
Co-authored-by: Jonas Zeltner <jonas.zeltner@posteo.de>
Co-authored-by: GeloCraft <115651305+gelocraft@users.noreply.github.com>
Co-authored-by: gelocraft <gelocraft@users.noreply.github.com>
Co-authored-by: Joaquín Guerra <joaquinguerratocino@gmail.com>
Co-authored-by: Rob <rcsfletcher@protonmail.com>
Co-authored-by: makeworld <25111343+makew0rld@users.noreply.github.com>
Co-authored-by: Aryan Rajoria <57455619+aryan-rajoria@users.noreply.github.com>
Co-authored-by: Ari Pollak <aripollak@users.noreply.github.com>
Co-authored-by: Crypto-Spartan <29098151+Crypto-Spartan@users.noreply.github.com>
Co-authored-by: Luca Saccarola <96259932+saccarosium@users.noreply.github.com>
Co-authored-by: RulentWave <49258216+RulentWave@users.noreply.github.com>
Co-authored-by: Sander <info@mesander.com>
Co-authored-by: dasvh <dasvh@protonmail.com>
Co-authored-by: Theo P. <63016528+theopn@users.noreply.github.com>
Co-authored-by: Dmytro Onypko <vaporif@gmail.com>
Co-authored-by: Liam Dyer <liamcdyer@gmail.com>
Co-authored-by: guru245 <guru245@users.noreply.github.com>
Co-authored-by: Ori Perry <48057913+oriori1703@users.noreply.github.com>
Co-authored-by: pynappo <lehtien.david@gmail.com>
Co-authored-by: Damjan 9000 <damjan.9000@gmail.com>
Co-authored-by: Omri Sarig <omri.sarig13@gmail.com>
Co-authored-by: Omri Sarig <omri.sarig@prevas.dk>
Co-authored-by: Carlos Calla Alarcón <calla.alarcon@gmail.com>
BiboursMogz added a commit to BiboursMogz/kickstart-modular.nvim that referenced this pull request Jan 3, 2026
* fix: minor misspellings (nvim-lua#1450)

* fix: minor misspellings

* revert change for `-Bbuild`

* Change LSP Keybindings to Match the Default `gr` Bindings Introduced in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention

* Remove Telescope `0.1` branch lock (nvim-lua#1448)

---------

Co-authored-by: dasvh <dasvh@protonmail.com>
Co-authored-by: Theo P. <63016528+theopn@users.noreply.github.com>
Co-authored-by: Dmytro Onypko <vaporif@gmail.com>
Co-authored-by: Damjan 9000 <damjan.9000@gmail.com>
sgt pushed a commit to sgt/kickstart.nvim that referenced this pull request Jan 6, 2026
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
psvkushal pushed a commit to psvkushal/kickstart.nvim that referenced this pull request Jan 9, 2026
…in Neovim 0.11 (nvim-lua#1427)

* refactor: change LSP keybindings to the default gr bindings introduced in 0.11

* refactor: modify existing LSP functions to follow  convention
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants