Skip to content

use main branch for treesitter to remove depracted vim.validate api #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnpekcan wants to merge 1 commit into from
Closed

use main branch for treesitter to remove depracted vim.validate api #1579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,8 +940,9 @@ require('lazy').setup({
},
{ -- Highlight, edit, and navigate code
'nvim-treesitter/nvim-treesitter',
branch = 'main',
lazy = false,
build = ':TSUpdate',
main = 'nvim-treesitter.configs', -- Sets main module to use for opts
-- [[ Configure Treesitter ]] See `:help nvim-treesitter`
opts = {
ensure_installed = { 'bash', 'c', 'diff', 'html', 'lua', 'luadoc', 'markdown', 'markdown_inline', 'query', 'vim', 'vimdoc' },
Copy link

@nilskruse nilskruse May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also been looking into this and I think the main branch, doesn't support those options at the time. Or am I missing something?

Copy link
Contributor Author

@johnpekcan johnpekcan May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right. seeing some unexpected behavior in treesitter now. My helm template files are actually rendering correctly as yaml now -- but setting filetype :set filetype=helm seems to break the syntax highlight again. :/

Copy link
Contributor Author

@johnpekcan johnpekcan May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe main branch isn't ready for prime time shrug

Copy link

@nilskruse nilskruse May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

return {
	"nvim-treesitter/nvim-treesitter",
	build = ":TSUpdate",
	branch = "main",
	config = function()
		require("nvim-treesitter").install({
			"c",
			"lua",
			"vim",
			"vimdoc",
			"query",
			"elixir",
			"heex",
			"javascript",
			"html",
			"rust",
			"dart",
		})
	end,
}

This is the closest I got to replicating the old behavior, but the other options are missing tho. Maybe this helps.

Copy link
Contributor Author

@johnpekcan johnpekcan May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! that certainly got us closer. but definitely different behavior still.

Expand Down