feat: Added queries for php#30
Merged
theHamsta merged 1 commit intonvim-treesitter:masterfrom Dec 13, 2020
Merged
Conversation
Member
|
Thanks for your contribution. Sorry for forgetting to review! Regarding (some_node .
(node_type) @function.inner.start
(node_type) @function.inner.end . ; the dot enforces this to be the last named node in this block "}" is not named
)However, some bug prevents to capture the last node when another nodes is captured at the same time. The above example would work with out What could also work would be this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took the liberty to add some queries for php. I still new on the query language. I was not able to get
if_statementto work correctly at the moment. Also, I wanted the ability to select the body of a function, excluding the
{and}.I reviewed Add @parameter.outer for Python/C/C++ PR but was not able the result that I am looking for. I am not sure if excluding the braces is feasibly in treesitter at the moment.