fix: Preprocess modules_dir to ensure successful module loading on Windows#50
Open
WindyValley wants to merge 3 commits intonvimdev:mainfrom
Open
fix: Preprocess modules_dir to ensure successful module loading on Windows#50WindyValley wants to merge 3 commits intonvimdev:mainfrom
modules_dir to ensure successful module loading on Windows#50WindyValley wants to merge 3 commits intonvimdev:mainfrom
Conversation
…Windows Probably for consistency with `vim.fn.stdpath`, `core.helper.path_join` uses '\' as the path separator on Windows. However, even on Windows, the path returned by `vim.fs.find` still uses `/`. This caused `pack:load_modules_packages` to error when extracting the module name from the module path. To avoid compatibility issues with other places where `core.helper.path_join` is used, only preprocess modules_path with `vim.fs.normalize` in `pack:load_modules_packages`.
…tfiles` with `Telescope nvim_user_config`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably for consistency with
vim.fn.stdpath,core.helper.path_joinuses '' as the path separator on Windows. However, even on Windows, the path returned byvim.fs.findstill uses/. This causedpack:load_modules_packagesto error when extracting the module name from the module path. To avoid compatibility issues with other places wherecore.helper.path_joinis used, only preprocess modules_path withvim.fs.normalizeinpack:load_modules_packages.