Fix: Reject bare LTS codenames in nvm install (fixes #3474) #3718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `nvm install Argon` would succeed by matching the LTS name in the version description (e.g., "v4.9.1 (Latest LTS: Argon)"), but `nvm uninstall Argon` would fail because "Argon" is not a valid alias or not a valid version. Changes: - Added pattern matching check in nvm_remote_version (nvm.sh:785-791) - Skips check for implicit aliases (node, stable, etc.) to preserve existing functionality - Added unit tests to verify LTS names are rejected while version numbers still work After this fix: - `nvm install Argon` → fails (use `nvm install lts/argon` instead) - `nvm install 4` → still works - `nvm install node` → still works - `nvm install lts/argon` → still works This makes install and uninstall behavior consistent.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users could run
nvm install Argon(or any LTS codename) and it would install successfully, butnvm uninstall Argonwould fail with "N/A version is not installed". This inconsistency was confusing.Root Cause: nvm_ls_remote uses grep which matches "Argon" in the description
v4.9.1 (Latest LTS: Argon), not just the version number.Solution
Added verification in nvm_remote_version to check if the search pattern actually exists in the version number (not just the description).
Changes
Behavior Changes
nvm install Argonnvm uninstall Argonnvm install lts/argonnvm install 4nvm install nodeTesting
nvm install Argon,nvm install 4,nvm install nodeFixes
nvm install Argonetc works, and should not #3474