This repository was archived by the owner on Mar 10, 2025. It is now read-only.
Remove unecessary sorts, add undefined check to packageJson sort#153
Conversation
☁️ Nx Cloud ReportCI ran the following commands for commit a9dcf5c. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
beeman
added a commit
that referenced
this pull request
Jan 20, 2022
Remove unecessary sorts, add undefined check to packageJson sort Merges #153
Contributor
|
Merged in #154 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nx 13+ already handles sorting the TsConfig paths and Workspace projects so I've removed them from the command so this now only sorts the package.json
scriptsproperty now.Added an undefined check to the sort function so that it doesn't add the property if it doesn't exist. Should never happen since package.json should always have the
scriptsproperty.Fixes:
#152