Namespace module names to enable submodules with the same folder name

[alexjreich]

For example:

- /data
  - /modules
    -/admin
-/stuff
  -/modules
     -/admin

Will create a boot exception for duplicate modules named admin.

Suggest we auto namespace submodules, so in the above, the modules would be data-admin and stuff-admin.

The side benefit of this is it would make finding submodules that throw nxus exceptions much easier - right now it can be hard to track down where exactly a submodule is in the tree.

[loppear]

Was just looking into this to have log messages be helpful, yep. Runs into some challenges with the proxy loading logic, it's easy to determine the right name when PluginManager is loading modules (recursing from a root) but harder for NxusModule to determine its place in the tree - currently the latter is responsible for its name (that's used for log, config, and application.get/proxy.use. Currently nested modules can't actually be used with application.get or with config from nxusrc reliably, so no loss/regression with those keys changing to something usable here.

It would be easy to have Application instantiate modules passing in the name to use in the constructor, except we have no consistency in modules accepting constructor arguments. So I think the fix will have to be NxusModule containing the logic to recurse up the tree to determine its name (probably terminating at package.json, dropping lib and modules segments).

I might tweak the name separator to be / - data/admin to indicate nesting rather than mixing -s.

[loppear]

Currently the name of the module depends who's asking, maybe the class name (for logging) and the dir name (in Application._moduleInfo), and we generally expect these to match-via-morph by having the default module exported by e.g. modules/home-page' be named HomePage. This isn't true for NxusModules that aren't loaded by Application e.g. modules/home-page/controllers/Welcome.js where we don't expect them to have config but they do currently log at their class name (welcome`)

So the names we want?

• modules/stuff/index.js -> stuff
• modules/stuff/controllers/ViewStuff.js -> stuff/controllers/view-stuff
• modules/stuff/modules/admin/index.js -> stuff/admin
• modules/stuff/modules/admin/controllers/index.js -> stuff/admin/controllers //unlikely case
• modules/stuff/modules/admin/controllers/StuffAdmin.js -> stuff/admin/controllers/stuff-admin