emitModelEvent does not return the promise

[loppear]

So code like await model.create(obj) doesn't have any way to wait on post-processing (by e.g. searcher), or to catch the errors caused by a model.create event handler.

Unlikely anything depends on this today, but changing it would potentially degrade response performance. (handlers could still be written to return immediately rather than their own promised result, so it would be possible to keep current behavior for those with long/inconsequential handlers)

[davidkellerman]

With an event-based approach like storage is using, I'm not clear on the "right" way of handling errors that occur in the event handlers. However, it seems that errors generated in the event handlers need to be reported in the completion status of the storage operation. (Recent experience with searcher leaving holes in its text indexes illustrates the point.)

The performance issue seems like a red herring. ("Perform the operation, but ignore any errors," is a bad tradeoff.) Run multiple operations in parallel for performance.

It seems like an error thrown in an event handler needs to be reported. And if the handler returns a Promise, the same applies if the Promise rejects. Is that going to break anything? You probably know better than I do. (The better question might be, "is it going to break anything that isn't cryptically broken already?")

There, my two bits. Glad you tracked down the issue. Yay, testing!