Skip to content

Conversation

@alexjreich
Copy link

@alexjreich alexjreich commented Aug 5, 2019

@loppear Let's discuss - a first take a fixing some lingering issues with editor components.

Specifically:

  1. Added in select2 for related/related-many.
  2. Fixed date/datetime handling fields with a pickers.
  3. Fixed button styling.
  4. Added in ability to override based on field name in addition to waterline model type.

@alexjreich alexjreich requested a review from loppear August 5, 2019 16:32
Copy link
Contributor

@loppear loppear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So probably this almost only impacts nxus-admin, since that's the primary thing using the form controller and inputs, but should probably be reviewed for impacts on any other projects that have web-form-input-* overrides, especially if there are any ones that also override the head.ejs theme partial.

Testing this out on infohub admin I'm getting strange behavior where the CSS <link> is appropriately in the page markup and served when accessed, but the datepicker is not themed:
admin-datepicker-styling
As you can see here, also incorrectly adding the time (00:00:00) onblur to these date fields, for reasons I don't see yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants