Add support for comparing by MIME.#69
Merged
Merged
Conversation
* zero API change; don't break current usage. * no change in time or space usage using benchmarks
Contributor
Author
|
@tmthrgd ptal when you have a chance. (seems like you are most aware of the issues this PR addresses) |
Contributor
Author
|
@jprobinson , I'm not totally sure what "approved" means in this context? Do I need to do anything or just wait until someone has approved and merged/committed? |
Contributor
|
I was out this afternoon and planned on merging in the morning. Didn't realize it was so urgent, @meirf. |
Contributor
Author
|
Thank you all for reviewing! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #68