Feature/docs update#551
Conversation
…ta and implementation status
…ta and updated implementation statuses
WalkthroughDocumentation updates mark many CMS blocks as returning mock data; a new Product data-model doc is added to the harmonization app; mocked payments-summary mapper updates remove Changes
Sequence Diagram(s)(omitted — changes are documentation and small mock-data mapper edits; no new multi-component control flow.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@apps/docs/docs/main-components/harmonization-app/normalized-data-model/core-model-products.md`:
- Around line 1-224: The Mermaid classDiagram incorrectly marks ProductType and
ProductReferenceType as <<enumeration>>; update the diagram so those symbols
reflect TypeScript union types instead of UML enumerations—either remove the
<<enumeration>> stereotype from ProductType and ProductReferenceType or replace
it with a note like "type union: 'PHYSICAL' | 'VIRTUAL'" and "type union:
'SPARE_PART' | 'REPLACEMENT' | 'COMPATIBLE_SERVICE'" respectively; keep the rest
of the diagram unchanged and ensure the labels ProductType and
ProductReferenceType match the exact type names used in the codebase.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
apps/docs/docs/integrations/cms/contentful/blocks.mdapps/docs/docs/integrations/cms/strapi/blocks.mdapps/docs/docs/main-components/harmonization-app/normalized-data-model/core-model-products.mdapps/docs/docs/main-components/harmonization-app/normalized-data-model/overview.md
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: marcinkrasowski
Repo: o2sdev/openselfservice PR: 411
File: packages/framework/src/modules/cms/models/blocks/product-list.model.ts:29-46
Timestamp: 2025-11-26T11:57:00.632Z
Learning: In the framework layer (packages/framework/src/modules/cms/models/blocks/*.model.ts), block classes like ProductListBlock should NOT include explicit __typename discriminators. The __typename field is added at the API harmonization layer (packages/blocks/*/src/api-harmonization/*.model.ts) where it's needed for discriminated unions. The framework maintains normalized data models without these discriminators.
📚 Learning: 2025-11-26T11:57:00.632Z
Learnt from: marcinkrasowski
Repo: o2sdev/openselfservice PR: 411
File: packages/framework/src/modules/cms/models/blocks/product-list.model.ts:29-46
Timestamp: 2025-11-26T11:57:00.632Z
Learning: In the framework layer (packages/framework/src/modules/cms/models/blocks/*.model.ts), block classes like ProductListBlock should NOT include explicit __typename discriminators. The __typename field is added at the API harmonization layer (packages/blocks/*/src/api-harmonization/*.model.ts) where it's needed for discriminated unions. The framework maintains normalized data models without these discriminators.
Applied to files:
apps/docs/docs/integrations/cms/strapi/blocks.md
🪛 LanguageTool
apps/docs/docs/main-components/harmonization-app/normalized-data-model/core-model-products.md
[grammar] ~113-~113: Ensure spelling is correct
Context: ...le.log(product.name)); }); ``` ### getRelatedProductList Retrieves a list of related products bas...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: deploy-preview
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (6)
apps/docs/docs/main-components/harmonization-app/normalized-data-model/overview.md (1)
17-17: LGTM! Products module documentation link added correctly.The new Products module reference is well-placed and accurately describes the module's purpose. The linked documentation file is included in this PR.
apps/docs/docs/integrations/cms/strapi/blocks.md (2)
44-46: LGTM! Product blocks documented as mock data.The product-related blocks are correctly documented with appropriate status indicators and notes explaining they return mock data pending full Strapi integration.
63-65: Clear documentation of mock data behavior.The explanations for product blocks returning mock data are clear and consistent with other mock data blocks in the documentation.
apps/docs/docs/integrations/cms/contentful/blocks.md (3)
36-38: Product blocks consistently documented as mock data.The product-related blocks (product-details, product-list, recommended-products) are correctly documented as returning mock data, consistent with the Strapi integration documentation.
74-76: Clear documentation in mocked blocks section.The product blocks are appropriately listed in the mocked blocks section with clear descriptions of what mock data they return.
24-24: Verified: Category block status accurately reflects current implementation.The
categoryblock in the Contentful integration indeed returns hardcoded mock data. The mapper atpackages/integrations/contentful-cms/src/modules/cms/mappers/blocks/cms.category.mapper.tscontains predefined mock category blocks (warranty-repair, maintenance, safety, accessories, troubleshooting) and themapCategoryBlockfunction uses a switch statement to return these based on ID and locale. There are no Contentful API queries. The documentation correctly reflects this state.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
… and remove layout property
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
What does this PR do?
Related Ticket(s)
Key Changes
How to test
Media (Loom or gif)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.