-
Notifications
You must be signed in to change notification settings - Fork 32
feature/adding ticket creation in Zendesk integration #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7fdec22
11a0a79
a373092
63a3632
f6136af
3c74660
e0dcebc
ddd3f2e
aafa372
d5bae10
b26bbf0
3345a27
023c478
e229c02
5d43c6a
140650d
18506a9
23dbf1e
7803964
d428fdd
05fdbb4
490c770
eab0016
f546490
8464a4c
11ffa81
7dd3363
b9a0a84
2e75c7a
2389087
302cec0
aa7d8de
52e381f
fba71f4
6d09572
a72a013
c9a7275
69f440c
d928907
6bd7086
cfd9d36
9b3b572
c7dad1a
5004678
fc99802
af98385
25c7cb6
b168499
26ce47a
42612b2
d8b75c2
ed7d564
2f80a73
13ecd36
91c77c4
e1d21c5
4092ffd
fb4e1e6
d3e111a
988d9f1
e01d4f5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| '@o2s/integrations.contentful-cms': minor | ||
| '@o2s/integrations.strapi-cms': minor | ||
| '@o2s/blocks.ticket-details': minor | ||
| '@o2s/blocks.ticket-recent': minor | ||
| '@o2s/integrations.zendesk': minor | ||
| '@o2s/integrations.mocked': minor | ||
| '@o2s/blocks.ticket-list': minor | ||
| '@o2s/modules.surveyjs': minor | ||
| '@o2s/api-harmonization': minor | ||
| '@o2s/framework': minor | ||
| '@o2s/docs': minor | ||
| --- | ||
|
|
||
| Added ticket creation functionality to the Zendesk integration. Users can now create tickets via POST /tickets with attachments and custom fields. Added custom field mapping from Survey.js format to Zendesk custom fields via new zendesk-field.mapper. Updated table columns on TicketList component to display: ticket type (topic), status, and last updated date. Added display of custom field values from ticket properties on TicketDetails. Updated mapper mocks in cms | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -11,14 +11,17 @@ graph TD | |||||||||||||
| A[PR Opened/Synchronized] --> B[skip-duplicate-check] | ||||||||||||||
| B --> C[changed-packages] | ||||||||||||||
| B --> D[build] | ||||||||||||||
| C --> O{Requires Changeset?} | ||||||||||||||
| O -->|Yes| P[check-changeset] | ||||||||||||||
| O -->|No| I[End] | ||||||||||||||
|
Comment on lines
+14
to
+16
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix Mermaid node ID collision. 🛠️ Proposed fix- C --> O{Requires Changeset?}
- O -->|Yes| P[check-changeset]
- O -->|No| I[End]
+ C --> RC{Requires Changeset?}
+ RC -->|Yes| P[check-changeset]
+ RC -->|No| I[End]📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
| C --> E{docs package changed?} | ||||||||||||||
| C --> L{stories changed?} | ||||||||||||||
| D --> F[lint] | ||||||||||||||
| D --> G[test] | ||||||||||||||
| F --> H[deploy-docs-preview] | ||||||||||||||
| G --> H | ||||||||||||||
| E -->|Yes| H | ||||||||||||||
| E -->|No| I[End] | ||||||||||||||
| E -->|No| I | ||||||||||||||
| H --> J[Prepare Environment] | ||||||||||||||
| J --> K[Deploy Docs to Vercel Preview] | ||||||||||||||
|
|
||||||||||||||
|
|
@@ -162,6 +165,7 @@ Runs code quality checks on PRs and deploys preview environments. | |||||||||||||
|
|
||||||||||||||
| - `skip-duplicate-check`: Prevents duplicate workflow runs | ||||||||||||||
| - `changed-packages`: Determines which packages/stories changed | ||||||||||||||
| - `check-changeset`: Checks if a changeset exists when required packages are modified | ||||||||||||||
| - `build`: Builds the project | ||||||||||||||
| - `lint`: Lints the code | ||||||||||||||
| - `test`: Runs tests | ||||||||||||||
|
|
@@ -205,6 +209,7 @@ Determines which packages have changed using Turborepo and detects Storybook cha | |||||||||||||
|
|
||||||||||||||
| - `package_changed`: JSON string containing changed packages information | ||||||||||||||
| - `stories_changed`: `true` if any `*.stories.tsx` or `.storybook/` files changed | ||||||||||||||
| - `requires_changeset`: `true` if changes require a changeset (framework/integrations/modules/blocks) | ||||||||||||||
|
|
||||||||||||||
| ### `deploy-vercel` | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,6 +42,7 @@ jobs: | |
| outputs: | ||
| package_changed: ${{ steps.determine-changes.outputs.package_changed }} | ||
| stories_changed: ${{ steps.determine-changes.outputs.stories_changed }} | ||
| requires_changeset: ${{ steps.determine-changes.outputs.requires_changeset }} | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v6 | ||
|
|
@@ -57,6 +58,35 @@ jobs: | |
| base-sha: ${{ github.event.pull_request.base.sha }} | ||
| fetch-depth: '0' | ||
|
|
||
| check-changeset: | ||
| needs: [skip-duplicate-check, changed-packages] | ||
| if: | | ||
| needs.skip-duplicate-check.outputs.should_skip != 'true' && | ||
| needs.changed-packages.outputs.requires_changeset == 'true' | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Check for changeset | ||
| shell: bash | ||
| env: | ||
| BASE_SHA: ${{ github.event.pull_request.base.sha }} | ||
| run: | | ||
| # Check if any .md file in .changeset (excluding README.md) has been modified/added in this PR | ||
| CHANGESET_DIFF=$(git diff --name-only $BASE_SHA | grep -E "^\.changeset/.*\.md$" | grep -v "README.md" || true) | ||
|
|
||
| if [ -z "$CHANGESET_DIFF" ]; then | ||
| echo "::error::No changeset found in this PR! You modified packages in framework, integrations, modules, or blocks." | ||
| echo "::error::Please run 'npm run changeset' to add a changeset describing your changes." | ||
| exit 1 | ||
| else | ||
| echo "Changeset found in PR:" | ||
| echo "$CHANGESET_DIFF" | ||
| fi | ||
|
Comment on lines
+61
to
+88
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ensure changeset check ignores deletions. 🛠️ Proposed fix- CHANGESET_DIFF=$(git diff --name-only $BASE_SHA | grep -E "^\.changeset/.*\.md$" | grep -v "README.md" || true)
+ CHANGESET_DIFF=$(git diff --name-only --diff-filter=AMR $BASE_SHA | grep -E "^\.changeset/.*\.md$" | grep -v "README.md" || true)🤖 Prompt for AI Agents |
||
|
|
||
| build: | ||
| needs: skip-duplicate-check | ||
| if: needs.skip-duplicate-check.outputs.should_skip != 'true' | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.