Conversation
added 3 commits
March 10, 2026 16:47
Contributor
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughRemoved Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Scaffolder
participant FS as "filesystem / package.json"
participant Versions as "integration package.jsons"
participant Cleanup as "cleanupProject"
participant TransformApps as "transformAppsPackageJson"
participant TransformConfigs as "transformIntegrationConfigs"
participant Installer as "installDependencies / package-lock"
User->>Scaffolder: npx create-o2s-app ...
Scaffolder->>FS: copy template files to temp/target
Scaffolder->>Versions: read integration package.jsons (capture integrationVersions)
Scaffolder->>Cleanup: cleanupProject(targetDir)
Cleanup->>FS: remove ALWAYS_REMOVE_DIRS & ALWAYS_REMOVE_FILES
Scaffolder->>TransformApps: transformAppsPackageJson(targetDir, selectedBlocks, selectedIntegrations)
TransformApps->>FS: read/modify apps package.json (deps & devDeps)
TransformApps->>FS: write updated package.json
Scaffolder->>TransformConfigs: transformIntegrationConfigs(targetDir, selectedIntegrations, integrationVersions)
TransformConfigs->>FS: update configs package.jsons and add missing selected integration deps using integrationVersions
Scaffolder->>Installer: installDependencies(targetDir, selectedIntegrations)
Installer->>FS: clean package-lock (remove symlinks, removed dirs, unselected integrations)
Installer->>FS: run npm install (unless skipInstall)
Scaffolder->>User: printSummary (watch scripts guidance)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan for PR comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Coverage Report for packages/configs/vitest-config
File CoverageNo changed files found. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/cli/create-o2s-app/src/constants.ts (1)
9-10:⚠️ Potential issue | 🟡 MinorUse the defined constants in
ALWAYS_REMOVE_DIRSto avoid string duplication.The
BLOCKS_PATHandINTEGRATIONS_PATHconstants (lines 9–10) are actively used inblock-discovery.tsandintegration-discovery.ts, so they are not dead code. However, the same paths are hardcoded as strings inALWAYS_REMOVE_DIRS(lines 18, 20), creating unnecessary duplication. Replace the hardcoded strings with references to these constants instead.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli/create-o2s-app/src/constants.ts` around lines 9 - 10, Replace the hardcoded directory strings in ALWAYS_REMOVE_DIRS with the exported constants to remove duplication: use BLOCKS_PATH and INTEGRATIONS_PATH (from constants.ts) instead of repeating 'packages/blocks' and 'packages/integrations' so ALWAYS_REMOVE_DIRS references those constants directly (update the array where ALWAYS_REMOVE_DIRS is defined).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/cli/create-o2s-app/src/constants.ts`:
- Around line 9-10: Replace the hardcoded directory strings in
ALWAYS_REMOVE_DIRS with the exported constants to remove duplication: use
BLOCKS_PATH and INTEGRATIONS_PATH (from constants.ts) instead of repeating
'packages/blocks' and 'packages/integrations' so ALWAYS_REMOVE_DIRS references
those constants directly (update the array where ALWAYS_REMOVE_DIRS is defined).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6492bc7b-c81e-408b-95a2-c29dbde80205
📒 Files selected for processing (13)
.changeset/afraid-cooks-battle.mdapps/docs/blog/releases/dxp/1.0.0.mdapps/docs/docs/app-starters/dxp/overview.mdapps/docs/docs/app-starters/o2s/overview.mdapps/docs/docs/getting-started/installation.mdapps/docs/docs/integrations/mocked/mocked.mdapps/docs/src/pages/product/starters.tsxpackages/cli/create-o2s-app/README.mdpackages/cli/create-o2s-app/src/constants.tspackages/cli/create-o2s-app/src/scaffold/cleanup.tspackages/cli/create-o2s-app/src/scaffold/index.tspackages/cli/create-o2s-app/src/scaffold/transform-apps-package-json.tspackages/cli/create-o2s-app/src/scaffold/transform-integration-configs.ts
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.changeset/heavy-ties-drop.md:
- Line 2: The changeset is incorrectly marked as a minor release; update the
changeset in ".changeset/heavy-ties-drop.md" so the package entry for
'create-o2s-app' uses the patch release level instead of minor (replace
'create-o2s-app': minor with 'create-o2s-app': patch or otherwise mark the
changeset as a patch), commit the updated changeset file so the package will be
released as a patch.
In `@packages/cli/create-o2s-app/src/utils/logger.ts`:
- Line 41: Replace the shell-dependent combined command string emitted by
console.log (the line printing "npm run watch:deps & npm run watch:apps") with a
platform-agnostic instruction: update the message in
packages/cli/create-o2s-app/src/utils/logger.ts so it tells users to run the two
commands in separate terminals (e.g., show two separate instructions or lines:
"npm run watch:deps" and "npm run watch:apps"), or alternatively mention
providing a cross-platform wrapper script; locate the console.log call that
prints "npm run watch:deps & npm run watch:apps" and change the text to guide
running them separately (or reference the wrapper) so Windows shells are not
broken.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 30fbe8e0-6b2a-4ce2-91d7-2c927730fe37
📒 Files selected for processing (2)
.changeset/heavy-ties-drop.mdpackages/cli/create-o2s-app/src/utils/logger.ts
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
marcinkrasowski
approved these changes
Mar 12, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/cli/create-o2s-app/src/scaffold/index.ts (1)
85-89: Avoid cleaningpackage-lock.jsontwice on the install path.
installDependencies()already callscleanPackageLock(), so the normal path reparses and rewrites the lockfile twice. Keep the explicit cleanup only forskipInstall, or delegate it entirely toinstallDependencies().Possible simplification
- await cleanPackageLock(targetDir, selectedIntegrations); - if (!skipInstall) { - await installDependencies(targetDir, selectedIntegrations); - } + if (skipInstall) { + await cleanPackageLock(targetDir, selectedIntegrations); + } else { + await installDependencies(targetDir, selectedIntegrations); + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli/create-o2s-app/src/scaffold/index.ts` around lines 85 - 89, The code currently calls cleanPackageLock(targetDir, selectedIntegrations) unconditionally and then calls installDependencies(...) which itself calls cleanPackageLock(), causing duplicate work; modify the scaffold sequence so cleanPackageLock is only invoked when skipInstall is true (i.e., keep the explicit cleanPackageLock call inside an if (skipInstall) branch) and remove the unconditional pre-install call, or alternatively remove the call here entirely and rely on installDependencies(targetDir, selectedIntegrations) to perform the cleanup; update references to cleanPackageLock, installDependencies, targetDir, selectedIntegrations, and skipInstall accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/cli/create-o2s-app/src/scaffold/index.ts`:
- Around line 22-28: The loop over selectedIntegrations currently skips missing
integration metadata and falls back to '0.0.0'; instead, in the block using
selectedIntegrations, INTEGRATIONS_PATH, path.join and pkgPath, fail fast: if
fs.pathExists(pkgPath) returns false throw a descriptive Error mentioning the
integration name and expected pkgPath, and after reading the JSON with
fs.readJson ensure pkg.version exists (not null/undefined) and throw if missing;
this guarantees versions[name] only gets valid versions and prevents silently
omitted or pinned-to-0.0.0 integrations.
---
Nitpick comments:
In `@packages/cli/create-o2s-app/src/scaffold/index.ts`:
- Around line 85-89: The code currently calls cleanPackageLock(targetDir,
selectedIntegrations) unconditionally and then calls installDependencies(...)
which itself calls cleanPackageLock(), causing duplicate work; modify the
scaffold sequence so cleanPackageLock is only invoked when skipInstall is true
(i.e., keep the explicit cleanPackageLock call inside an if (skipInstall)
branch) and remove the unconditional pre-install call, or alternatively remove
the call here entirely and rely on installDependencies(targetDir,
selectedIntegrations) to perform the cleanup; update references to
cleanPackageLock, installDependencies, targetDir, selectedIntegrations, and
skipInstall accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f26efa50-1d9c-4ae9-b02a-5e89afa7bac6
📒 Files selected for processing (4)
.changeset/rich-friends-travel.mdpackages/cli/create-o2s-app/src/scaffold/index.tspackages/cli/create-o2s-app/src/scaffold/install.tspackages/cli/create-o2s-app/src/scaffold/transform-integration-configs.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- packages/cli/create-o2s-app/src/scaffold/transform-integration-configs.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related Ticket(s)
Key Changes
How to test
Media (Loom or gif)
Summary by CodeRabbit
Documentation
New Features
Bug Fixes