Feat/replace token strategy by pledge manager#11
Closed
Conversation
…ress instead of token ID
…te refund logic to use backer address
…oken ID dependencies and updating refund logic to utilize backer address
…ons to use totalPledged and enhancing pause/unpause functionality
…e pledge and refund logic, and enhance fee disbursement calculations
…pledged, update refund logic, and implement fee disbursement calculations
…ace pledged amount with fee disbursement status, and update withdrawal process to reset total pledged after withdrawal
…able, ensure fees are disbursed before withdrawal, and prevent over-disbursement during fee calculations
…acing manual calculations with a dedicated internal function
…fee disbursement logic, enhancing code reusability and clarity.
rayedsikder
pushed a commit
that referenced
this pull request
Dec 9, 2025
* Fix incorrect description of the `claimFund` function (#6) (immunefi)(issue#06) - Updated the NatSpec comment for claimFund() * Refactor `platformDataKey` parameter validation optimization (#7) (immunefi)(issue#09) - Move `platformDataKey` parameter validation to an earlier stage of the `createCampaign` flow * Add configuring platform data during `updateSelectedPlatform` (#8) (immunefi)(issue#10) * Add creator's non-zero validation during `createCampaign` (#9) (immunefi)(issue#16) * Add zero validation for `platformDataValue` in `createCampaign` (#10) (immunefi)(issue#12) * Add reward value zero validation in pledge (#11) (immunefi)(issue#14) * Fix `updateDeadline` allowing past deadline that blocks `claimRefund` (#12) (immunefi)(issue#05) - Added check to ensure new deadline is after current block timestamp * Fix blocking KeepWhatsRaised pledge functions via front-running (#13) (immunefi)(issue#04) - Add internal pledge ID generation using msg.sender and pledgeId * Add fee configuration via configure treasury (#14) (immunefi)(issue#11) - Update configure treasury to support fee values - Add getter function for fee value * Add campaign data validation in configure treasury (#15) (immunefi)(issue#20) - Update fee values js doc - Update custom error * Fix Gateway fee bypass (#16) (immunefi)(issue#19) - When `setFeeAndPledge` is called, tokens are transferred from the admin's wallet (msg.sender) - When `pledgeWithoutAReward` or `pledgeForAReward` is called directly, tokens are transferred from the backer's wallet * Add expected fee description in create campaign jsdoc (#17) (immunefi)(issue#03) * Refactor withdrawal and pledge calculation (#19) (immunefi)(issue#15) (immunefi)(issue#18) - Restrict access to the withdrawal function so that only the campaign owner and platform administrator can use it. - Move the protocol fee calculation from the withdrawal process to the pledge stage. - For withdrawals: - Partial Withdrawals: - Conditions: amount > 0 and amount + fees ≤ available balance. - The creator must specify the exact withdrawal amount, and the system will ensure there are sufficient funds to cover both the withdrawal and the fees. - Final Withdrawals: - Conditions: available balance > 0 and fees ≤ available balance. - The creator can withdraw the entire remaining balance. The system will check if there are enough funds to cover the fees and will then provide the remainder to the creator. --------- Co-authored-by: mahabubAlahi <mahabub@ccprotocol.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer
WIP BRANCH
This PR refactors the treasury contracts to improve code maintainability, reduce duplication, and align the logic with the PledgeManager abstraction. The changes include:
Centralized Fee Disbursement Logic
The disbursement fees logic, previously duplicated across BaseTreasury, AllOrNothing, and MinimumOrder, has been centralized into the BaseTreasury contract.
A new internal function _disburseFeesInternal in BaseTreasury handles the common logic for fee disbursement. Derived contracts now call this function, reducing redundancy.
Transition to PledgeManager
Removed legacy crypto-token-based tracking and replaced it with PledgeManager's totalPledged for managing pledges.
Simplified pledge-related operations (e.g., refunds, confirmations) by leveraging PledgeManager's centralized logic.
Removed Redundant State Variables:
Eliminated unnecessary variables like s_cryptoFeeDisbursed and redundant pledge tracking in derived contracts, as PledgeManager already provides this functionality.
Improved Maintainability
Consolidated shared logic into reusable functions in BaseTreasury.
Simplified derived contracts (AllOrNothing and MinimumOrder) by delegating everyday operations to BaseTreasury and PledgeManager.
Installment-Ready Foundation
The refactoring lays the groundwork for future installment-based functionality by centralizing pledge and fee management, making it easier to extend the system.
Impact
Testing