Replace ethabi

[abukosek]

Closes #2274.

Since the ethabi crate is no longer maintained and the new version of evm has a dependency incompatibility with it, we should switch to something else.

The ethabi crate recommends solabi as the replacement, so let's try that...

This PR changes the majority of ethabi uses into solabi, but a few have been left for @njelich to do while I'm on vacation :)
(Those are the evm_derive macros and erc20 precompiles [and tests related to them], as well as a few bits here and there that I probably missed.)

[netlify]

✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.

Name	Link
🔨 Latest commit	09d757e
🔍 Latest deploy log	https://app.netlify.com/projects/oasisprotocol-oasis-sdk/deploys/68c02ace5e0c340008aa8aa9

[codecov]

Codecov Report

❌ Patch coverage is 72.56098% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.66%. Comparing base (7c3b1fb) to head (02678ea).
⚠️ Report is 19 commits behind head on main.

Files with missing lines	Patch %	Lines
runtime-sdk/modules/evm/src/types.rs	23.80%	16 Missing ⚠️
runtime-sdk/modules/rofl-market/src/payment.rs	0.00%	15 Missing ⚠️
...ime-sdk/modules/evm/src/precompile/confidential.rs	80.55%	7 Missing ⚠️
runtime-sdk-macros/src/evm_derive.rs	54.54%	5 Missing ⚠️
runtime-sdk/modules/evm/src/precompile/subcall.rs	77.77%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2282      +/-   ##
==========================================
+ Coverage   52.39%   53.66%   +1.26%     
==========================================
  Files         175      176       +1     
  Lines       13094    13127      +33     
==========================================
+ Hits         6861     7045     +184     
+ Misses       6233     6082     -151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[njelich]

@matevz The rewrite is more or less done, but currently blocked due to solabi not supporting packed encoding, which is needed to complete the signed_call rewrite. Should I add packed encoding support to solabi or use another library?

https://github.com/oasisprotocol/oasis-sdk/pull/2282/files#diff-21774ace7dc2170065f7b77e0f9a0e69cb1f26ab5773dc6b412530a5ac2504c0R196-R225

[njelich]

Need to check benchmarks for memory, binary size and speed between ethabi, solabi, alloy.

[njelich]

Reported on the benchmarks - solabi is about 2x faster and has a smaller binary than alloy, both on static and dynamic encoding tests. Proceeding to add support for packed encoding to solabi.

[abukosek]

Generally looks OK, but please change the following:

1. Sensibly join commits and use our style: https://github.com/oasisprotocol/oasis-core/blob/master/CONTRIBUTING.md#git-commit-messages
2. There are some commented-out lines of code left -- either uncomment them or remove them (also extra whitespace).
3. Run cargo fmt.
4. Rebase to latest main.
5. Re-run tests and linters on CI and make any adjustments to the code if necessary.

Also, it currently doesn't compile because of mbedtls errors (the version was probably bumped by accident, please undo that -- updating that should be done in a separate PR).

I'll do another review pass after these are done :)

[njelich]

@abukosek Could you please take a look at the build issue to do with defguard_wireguard_rs package? Everything else is resolved.

[kostko]

The breakage is related to the issue I mentioned a few days ago, upstream is working on a fix due to incorrect semver bump.

See:

• Patch version update causes breakage rust-netlink/netlink-packet-wireguard#13
• Crate is broken due to netlink-* bumps DefGuard/wireguard-rs#94

[njelich]

Upstream seems to have merged 10 minutes ago (DefGuard/wireguard-rs#95)

[njelich]

@abukosek Please reviw so I can merge - CI now passes.

[abukosek]

The solabi packed encoding PR has been merged, so you can bump the solabi versions to the latest 0.3.0 :)

[njelich]

Updated

[njelich]

@abukosek Linted, formatted, and reviewed for any remaining comments (leaving the comments inside functions describing functionality as normal ones), and removed unneeded prints.

[abukosek]

As I've said previously, comments must end with periods to be consistent with the rest of our coding style :)

[abukosek]

Looks good now! 👍

GitHub says that "Pull request authors can’t approve their own pull request.", so someone else will have to approve it before it can be merged :D