feat: enable tree-shaking by moving provider dispatch to factory pattern#7
Merged
feat: enable tree-shaking by moving provider dispatch to factory pattern#7
Conversation
Replace the switch statement in handler.go (which forced all 5 UI providers into every binary) with a DocsHandlerFactory field set by each With<Provider> option. The Go linker now eliminates any provider whose option is never called, reducing binary size to only the provider(s) in use. - Remove default StoplightElements provider; callers must now explicitly specify a provider via WithSwaggerUI, WithStoplightElements, etc. - Cache the docs handler with sync.Once so template parsing happens once - Simplify DocsFunc to resolve the handler at registration time
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the switch statement in handler.go (which forced all 5 UI providers into every binary) with a DocsHandlerFactory field set by each With option. The Go linker now eliminates any provider whose option is never called, reducing binary size to only the provider(s) in use.