[PR #37] p1-core: contracts/test/ absent — no fork tests for live liquidation logic

[obchain]

PR: #37 feat(contracts): full Aave + Venus + PancakeSwap liquidation flow
Commit: 54fe2bb
File: contracts/ (test/ directory absent entirely)

Problem: PR #37 introduces complete on-chain liquidation path — flash-loan callback, Venus liquidateBorrow, vToken redeem, PancakeSwap swap, profit sweep — but ships zero Forge tests. PRD acceptance requires fork-test coverage of full flow before contract reviewable for production. Three p0 bugs (evm_version, pragma, cold wallet) and two p1 bugs (vBNB path, fee tier) in this PR would have been caught by one fork test replaying a real BSC liquidation.

Impact: No regression barrier. Future PRs can silently break liquidation callback, change profit accounting, or introduce new collateral paths without any test failure. Reviewers / auditors must manually trace logic without runnable reference.

Fix: Add contracts/test/CharonLiquidator.t.sol with Forge fork tests targeting BSC mainnet (rpc_endpoints.bnb already wired in foundry.toml). Minimum coverage:

1. Happy path: BNB flash-loan, USDT debt liquidation, USDT collateral swap.
2. vBNB collateral path: verify WBNB wrap and correct colBal after fix.
3. Wrong fee tier: assert revert when fee=3000 passed for BTCB pair.
4. Profit routing: assert COLD_WALLET (not owner) receives profit after fix.
5. Access control: executeOperation reverts when called by non-Aave address.

[obchain]

Not fixed on feat/12-charon-liquidator-full — deferred to the dedicated fork-test PRs that already ship the coverage requested here.

• PR test(contracts): CharonLiquidator unit + reentrancy + skipped fork #38 (branch feat/13-foundry-fork-tests) adds CharonLiquidator unit + reentrancy + skipped fork coverage.
• PR test(contracts): CharonLiquidator fork-test suite across 5 Venus markets #53 (branch feat/25-foundry-fork-tests) adds the full fork-test suite across five Venus markets.

Adding a parallel contracts/test/ tree here would duplicate those PRs and create merge churn. The three p0/p1 logic fixes landed on this branch (#120 cold wallet, #121 vBNB wrap, #122 configurable fee tier) will be exercised by the fork tests in #38 / #53 once those branches rebase onto the updated constructor signature and LiquidationParams layout.

Tracking in #38 and #53. Closing this duplicate.