Skip to content

[PR #38] p2: floating ^0.8.24 pragma in CharonLiquidator.t.sol #125

@obchain

Description

@obchain

Summary

contracts/test/CharonLiquidator.t.sol line 3 declares pragma solidity ^0.8.24;. The caret makes the compiled bytecode non-deterministic: any solc release from 0.8.24 through <0.9.0 is permitted by the pragma. A future solc release could change codegen, optimizer behavior, or introduce breaking changes that are invisible until the build environment is updated.

Issues #113 and #119 track this defect on the production contracts. This issue tracks the identical defect introduced by the new test file.

Location

contracts/test/CharonLiquidator.t.sol:3

pragma solidity ^0.8.24;  // should be: pragma solidity 0.8.24;

Fix

Change to the exact version: pragma solidity 0.8.24;

This must be done consistently with the fix for #113 / #119 when those are resolved.

Refs #38

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions